Open
Conversation
|
@Mixaill Thanks for the contribution. I wonder if we should also add u32 and i64? Although not used currently, I find it more convenient to have these functions predefined for the common types. One would expect u32 to exist when i32 exists and vice versa. @abraxa Any opinion on this? Otherwise, this is OK to merge -- though I'd be happier to see all the types included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spinoff from #275, needed for convenient operations with
SR_CONF_NUM_LOGIC_CHANNELSwhich isSR_T_INT32