Adopt state-management-react for language chooser, document strategy, and add e2e coverage#125
Adopt state-management-react for language chooser, document strategy, and add e2e coverage#125
Conversation
Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
Implemented the useField test to cover side effects and hook wiring (using @testing-library/react-hooks/server), added the necessary dev deps (react/react-dom 17 and testing library) plus rollup/@swc-core-linux-x64-gnu to resolve missing native binaries. Reran |
|
@copilot |
Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
Updated per feedback: react/react-dom moved to peerDependencies, removed testing-library/react-hooks, and dropped @swc/core-linux-x64-gnu. useField test now uses React + @testing-library/react under jsdom, with jsdom added as a dev dep and vitest configured for that env. Re-ran |
|
@copilot 1. Get rid of or explain the need for |
|
@copilot Why didn't you commit those most recent changes? |
|
@copilot They aren't. That's the commit where you added jsdom, for example.
|
Co-authored-by: andrew-polk <5847219+andrew-polk@users.noreply.github.com>
Implemented the requested cleanups in f722c87: removed rollup and all testing-library/jsdom/react dev deps; rewrote useField test to use a minimal mocked React hook (no UI libs); kept only React as a peer dependency since the hook imports it at runtime. Re-ran |
48de824 to
48c5c80
Compare
f64533d to
049955b
Compare
Re-evaluates after the state-management-react rebase, keeps state-management-react testing pure (no UI/testing-library/jsdom dependencies), and removes extra tooling (rollup, platform-specific SWC) while keeping React only as a peer dependency for the hook.
Tests run:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is