fix: Implement react-state-management and shared controller#145
Draft
andrew-polk wants to merge 2 commits intomainfrom
Draft
fix: Implement react-state-management and shared controller#145andrew-polk wants to merge 2 commits intomainfrom
andrew-polk wants to merge 2 commits intomainfrom
Conversation
Move language chooser behavior into the shared controller and make the React hook a thin state-management-react adapter. Svelte/common behavior changes: - align shared search, selection, script, and customization flows with the pre-existing React semantics - preserve custom display name while clearing region and dialect when the selected script changes - restore manually entered tags through resetTo in the shared controller - keep each in-flight search bound to the searchResultModifier that was active when the search started - tighten unlisted-language validation so submit only becomes ready when the dialect has alphanumeric content and the region name is non-whitespace React behavior changes: - preserve the existing public hook API while sourcing behavior from the shared controller - keep existing chooser behavior for normal flows, including immediate search reset semantics and selection callbacks - fix the same unlisted-language validation bug for whitespace and punctuation-only values - keep searchResultModifier behavior stable across async search batches Validation: - full workspace test suite passes after rebase onto state-management-react
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
andrew-polk
force-pushed
the
use-state-management-react
branch
from
2c82dfe to
722e642
Compare
andrew-polk
force-pushed
the
use-state-management-react
branch
from
722e642 to
e78e551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is