Skip to content

Remove Windows' carriage returns#6

Merged
imnasnainaec merged 1 commit intomainfrom
bugfix/cut-win-carriage-returns
Mar 27, 2026
Merged

Remove Windows' carriage returns#6
imnasnainaec merged 1 commit intomainfrom
bugfix/cut-win-carriage-returns

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Mar 26, 2026

https://gallery.ecr.aws/thecombine/aws-kubectl version 0.4.0 was built on Windows and secretly had /r/n line endings. This can cause the script to crash on Linux. Specifically, the first line of scripts/ecr-get-login.sh is

#!/usr/bin/env sh

which can result in:

/usr/bin/env: 'sh\r': No such file or directory

Version 0.4.1 is based on this branch.

https://app.devin.ai/review/sillsdev/aws-kubectl/pull/6

@imnasnainaec imnasnainaec self-assigned this Mar 26, 2026
@imnasnainaec imnasnainaec added the bug Something isn't working label Mar 26, 2026
@imnasnainaec imnasnainaec marked this pull request as ready for review March 26, 2026 19:58
@imnasnainaec imnasnainaec changed the title Remove Window's carriage returns Remove Windows' carriage returns Mar 26, 2026
@imnasnainaec imnasnainaec merged commit 3f49e8b into main Mar 27, 2026
2 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/cut-win-carriage-returns branch March 27, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants