dev: enable nullable where no errors, treat warnings as errors

src/SIL.XForge.Scripture/Controllers/MachineApiController.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Controllers/ParatextController.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SIL.XForge.Scripture/Controllers/SFProjectsRpcController.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge.Scripture/Controllers/SFProjectsUploadController.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SIL.XForge.Scripture/DataAccess/SFDataAccessServiceCollectionExtensions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Microsoft.Extensions.Configuration;
 using MongoDB.Driver;
 using SIL.XForge.DataAccess;

src/SIL.XForge.Scripture/Migrator.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Diagnostics;
 using System.IO;

src/SIL.XForge.Scripture/Models/AudioTiming.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 public class AudioTiming

src/SIL.XForge.Scripture/Models/EditorTabPersistData.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/InviteeStatus.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 public class InviteeStatus

src/SIL.XForge.Scripture/Models/Like.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 public class Like

src/SIL.XForge.Scripture/Models/Note.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>Represents a project note.</summary>

src/SIL.XForge.Scripture/Models/NoteSyncMetricInfo.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/NoteThread.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using SIL.XForge.Models;
 

src/SIL.XForge.Scripture/Models/OnboardingRequest.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using SIL.XForge.Models;

src/SIL.XForge.Scripture/Models/ParatextResource.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Globalization;
 using System.Text;

src/SIL.XForge.Scripture/Models/ParatextUserProfile.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/Question.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using SIL.XForge.Models;

src/SIL.XForge.Scripture/Models/ResourceConfig.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 
 namespace SIL.XForge.Scripture.Models;

src/SIL.XForge.Scripture/Models/SFProjectCreateSettings.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/SFProjectUserConfig.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using SIL.XForge.Models;

src/SIL.XForge.Scripture/Models/ServalBuildDto.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 public class ServalBuildDto : ServalResourceDto

src/SIL.XForge.Scripture/Models/ServalResourceDto.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/SyncMetricInfo.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/SyncMetrics.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using SIL.XForge.Models;

src/SIL.XForge.Scripture/Models/TextAnchor.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 /// <summary>

src/SIL.XForge.Scripture/Models/TextAudio.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using SIL.Scripture;
 using SIL.XForge.Models;

src/SIL.XForge.Scripture/Models/TextData.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using Newtonsoft.Json;
 using SIL.Scripture;

src/SIL.XForge.Scripture/Models/TransceleratorQuestion.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Scripture.Models;
 
 public class TransceleratorQuestion

src/SIL.XForge.Scripture/Models/TranslateMetrics.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using SIL.XForge.Models;
 

src/SIL.XForge.Scripture/Models/TranslateSource.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using SIL.XForge.Models;
 
 namespace SIL.XForge.Scripture.Models;

src/SIL.XForge.Scripture/Models/VerseRefData.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using SIL.Scripture;
 
 namespace SIL.XForge.Scripture.Models;

src/SIL.XForge.Scripture/Pages/Shared/_Footer.cshtml

@@ -8,6 +8,7 @@
 @inject IOptions<RequestLocalizationOptions> LocOptions
 
 @{
+    #nullable disable warnings
     var requestCulture = Context.Features.Get<IRequestCultureFeature>();
     InterfaceLanguage? locale = LocOptions.Value.SupportedUICultures?.Where(c =>
     SharedResource.Cultures[c.IetfLanguageTag].Tags.Contains(requestCulture.RequestCulture.UICulture.Name)

src/SIL.XForge.Scripture/Pages/Shared/_SelectLanguagePartial.cshtml

@@ -28,9 +28,12 @@
         @* Include the query string so users return to the exact page (including errors/404) after changing language. *@
         <input type="hidden" name="returnUrl" value="@(Context.Request.Path + Context.Request.QueryString)" />
         <div class="mdl-textfield mdl-js-textfield mdl-textfield--floating-label">
-            <select name="culture" class="mdl-textfield__input" onchange="this.form.submit();"
-                    asp-for="@requestCulture.RequestCulture.UICulture.Name" asp-items="cultureItems">
-            </select>
+            @if (requestCulture != null)
+            {
+                <select name="culture" class="mdl-textfield__input" onchange="this.form.submit();"
+                        asp-for="@requestCulture.RequestCulture.UICulture.Name" asp-items="cultureItems">
+                </select>
+            }
         </div>
     </form>
 </div>

src/SIL.XForge.Scripture/Program.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.IO;
 using System.Reflection;
 using Microsoft.AspNetCore;

src/SIL.XForge.Scripture/SIL.XForge.Scripture.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
     <TypeScriptToolsVersion>Latest</TypeScriptToolsVersion>
     <IsPackable>false</IsPackable>
@@ -10,7 +11,7 @@
     <UserSecretsId>4d0606c3-0fc7-4d76-b43b-236485004e81</UserSecretsId>
     <RealtimeServerRoot>..\RealtimeServer\</RealtimeServerRoot>
     <AngularConfig>production</AngularConfig>
-    <Nullable>annotations</Nullable>
+    <Nullable>enable</Nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <!-- Suppress complier warning "Missing XML comment for publicly visible type or member" -->
     <NoWarn>$(NoWarn);1591</NoWarn>

src/SIL.XForge.Scripture/Services/BuildConfigJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using Newtonsoft.Json;
 using SIL.XForge.Scripture.Models;

src/SIL.XForge.Scripture/Services/DeltaUsxExtensions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Newtonsoft.Json.Linq;
 using SIL.XForge.Realtime.RichText;
 

src/SIL.XForge.Scripture/Services/DeltaUsxMapper.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge.Scripture/Services/DotNetCoreRegistry.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Microsoft.Win32;
 using PtxUtils;
 

src/SIL.XForge.Scripture/Services/HgWrapper.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.IO;
 using System.Linq;

src/SIL.XForge.Scripture/Services/IParatextService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Threading;

src/SIL.XForge.Scripture/Services/IScrTextCollection.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Paratext.Data;
 using Paratext.Data.ProjectFileAccess;
 

src/SIL.XForge.Scripture/Services/InternetSharedRepositorySourceProvider.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;

src/SIL.XForge.Scripture/Services/JwtInternetSharedRepositorySource.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Services/JwtTokenHelper.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Diagnostics;
 using System.IdentityModel.Tokens.Jwt;

src/SIL.XForge.Scripture/Services/LambdaTraceListener.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Text;
 

src/SIL.XForge.Scripture/Services/LazyScrTextCollection.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.IO;
 using System.Linq;
 using System.Xml.Linq;

src/SIL.XForge.Scripture/Services/MachineApiService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;

src/SIL.XForge.Scripture/Services/MachineProjectService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;

src/SIL.XForge.Scripture/Services/MachineServiceCollectionExtensions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Net;
 using System.Net.Http;

src/SIL.XForge.Scripture/Services/MutexAttribute.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Globalization;
 using Hangfire.Common;

src/SIL.XForge.Scripture/Services/NotesFormatter.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;

src/SIL.XForge.Scripture/Services/ParatextDataHelper.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge.Scripture/Services/ParatextNotesMapper.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Services/ParatextService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/SIL.XForge.Scripture/Services/ParatextSyncRunner.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Services/PersistedParatextDataSettings.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Paratext.Data;
 using PtxUtils;
 

src/SIL.XForge.Scripture/Services/PersistedPtxUtilsSettings.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using PtxUtils;
 
 namespace SIL.XForge.Scripture;

src/SIL.XForge.Scripture/Services/PreTranslationService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Linq;

src/SIL.XForge.Scripture/Services/SFApplicationBuilderExtensions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using Microsoft.Extensions.DependencyInjection;
 using SIL.XForge.Scripture.Services;
 

src/SIL.XForge.Scripture/Services/SFInstallableDblResource.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SIL.XForge.Scripture/Services/SFProjectRights.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SIL.XForge.Scripture/Services/SFProjectService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge.Scripture/Services/SFScrTextCollection.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.IO;

src/SIL.XForge.Scripture/Services/SyncService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Threading;
 using System.Threading.Tasks;

src/SIL.XForge.Scripture/Services/TrainingDataService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge.Scripture/Services/TransceleratorService.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;

src/SIL.XForge.Scripture/SharedResource.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;

src/SIL.XForge.Scripture/Startup.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System;
 using System.Collections.Generic;
 using System.Globalization;

src/SIL.XForge/Configuration/AudioOptions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Configuration;
 
 /// <summary>

src/SIL.XForge/Configuration/DataAccessOptions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Configuration;
 
 public class DataAccessOptions

src/SIL.XForge/Configuration/ParatextOptions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 namespace SIL.XForge.Configuration;
 
 public class ParatextOptions

src/SIL.XForge/Configuration/RealtimeOptions.cs

@@ -1,3 +1,4 @@
+#nullable disable warnings
 using System.Collections.Generic;
 using SIL.XForge.Models;