Skip to content

Use environment secrets for Crowdin actions#3753

Merged
Nateowami merged 1 commit intomasterfrom
actions/use-env-for-crowdin
Mar 23, 2026
Merged

Use environment secrets for Crowdin actions#3753
Nateowami merged 1 commit intomasterfrom
actions/use-env-for-crowdin

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Mar 21, 2026

Zizmor has flagged our use of secrets outside an environment as not being a security best-practice, since it means the secrets are available to every action that runs. See https://docs.zizmor.sh/audits/#secrets-outside-env

Instead, secrets should be put in an environment (e.g. a "Crowdin" environment), and then workflows should state which environment they use.

What that means is that the security improvement isn't an update to a workflow; it's a change to how our secrets are stored in GitHub, to have better access control. However, doing that does necessitate an update to the workflows.

I've created a Crowdin environment in the repo settings, set CROWDIN_PROJECT_ID and CROWDIN_API_KEY, and updated the workflow to reference them. After this is merged the old secrets should be removed from the repo's main secrets, so they're only available via the environment.


Open with Devin

This change is Reviewable

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.31%. Comparing base (5b88991) to head (cc28415).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3753   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         620      620           
  Lines       39080    39080           
  Branches     6371     6352   -19     
=======================================
  Hits        31778    31778           
- Misses       6317     6330   +13     
+ Partials      985      972   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-assigned this Mar 22, 2026
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@Nateowami Nateowami force-pushed the actions/use-env-for-crowdin branch from 045a6c0 to cc28415 Compare March 23, 2026 16:50
@Nateowami Nateowami changed the title Use environment secrets for Crowdin Use environment secrets for Crowdin actions Mar 23, 2026
@Nateowami Nateowami enabled auto-merge (squash) March 23, 2026 16:53
@Nateowami Nateowami merged commit 72e6cbc into master Mar 23, 2026
21 of 22 checks passed
@Nateowami Nateowami deleted the actions/use-env-for-crowdin branch March 23, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants