[LIQ] Extend with group by and having with aggregators - #1843
Merged
Conversation
Also update documentation with extensive examples and add some parser tests. Note: `make generate` JS files included. Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
mjf
marked this pull request as draft
February 20, 2026 12:43
Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
mjf
changed the title
group by and having supportgroup by and having with aggregators
mjf
marked this pull request as ready for review
February 24, 2026 08:08
zefhemel
requested changes
Feb 25, 2026
zefhemel
left a comment
zefhemel
left a comment
Collaborator
There was a problem hiding this comment.
Overall I really like this, I think this adds a lot of power tot he LIQ sub-language. My main concern is about how aggregator functions become a "special" citizen. I'd really prefer this if would not be required, but the whole thing is not clear enough in my head to be able to judge if this is fundamentally possible. I put a comment on this topic in the aggregates.ts file
If you can find a way where aggregate functions just become Lua tables adhering to a particular interface, I'd much prefer that than to introduce a magic new thing only used/valid in the context of LIQ.
Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
…de block type to `lua` Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
Signed-off-by: Matouš Jan Fialka <mjf@mjf.cz>
zefhemel
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update documentation with extensive examples and add some parser tests.
Note:
make generateJS files included.