ENH Rewrite front-end JS in vanilla JS#1197
ENH Rewrite front-end JS in vanilla JS#1197fonsekaean wants to merge 15 commits intosilverstripe:5from
Conversation
|
Interesting start, keen to see results of the tests. It's also quite hard to read the JS file diff since everything changed. |
GuySartorelli
left a comment
There was a problem hiding this comment.
I assume based on the failed tests that this isn't ready yet - should this be a draft?
@GuySartorelli for some modules tests are failing on composer install, it can't get some core dependencies. Similar for e.g. contentreview module. It's not a functional issue, it doesn't even get to testing that. |
|
Ahh, I didn't even think to click through to see if the failures were something like that 😅 |
|
@fonsekaean Just to be clear, as I see you're occasionally making new commits to this - is this still a work in progress, or is it ready for review? |
|
@GuySartorelli its all done, I was testing it on a project and found a specific issue that I sorted. |
|
did another commit and that should be the last one @GuySartorelli |
|
And another one.. I reckon we probably need a wider testing/more experience with the change before we accept the PR. |
|
The pagination and progress title failing tests seem relevant. |
|
I will check that one out. Also did some slight updates today as well |
This removed the requirement of jQuery on front end validations, display rules and step navigations.