Merged
Conversation
zurekz
requested changes
Apr 10, 2026
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamRoomConnectionNotInitialized, "StreamRoom connection not initialized", 0x0020) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamHandleNotInitialized, "StreamHandle not initialized", 0x0021) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamIsPublished, "Stream is published", 0x0022) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamIsPublishedException, "Stream is published", 0x0022) |
Member
There was a problem hiding this comment.
StreamIsPublishedException -> StreamAlreadyPublishedException
should be: "Stream is already published"
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, InvalidEncryptionKeyIdLengthException, "Invalid encryption key id length", 0x002A); | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, InvalidMessageHeaderLengthException, "Invalid message header length", 0x002B); | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, UnsupportedMessageFormatVersionException, "Unsupported message format version length", 0x002C); | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamRoomAlreadyJoinedException, "StreamRoom already joined", 0x002D) |
Member
There was a problem hiding this comment.
StreamRoomAlreadyJoinedException -> AlreadyJoinedStreamRoomException
should be: "Cannot join stream room: already connected"
kisielewski
approved these changes
Apr 10, 2026
zurekz
requested changes
Apr 10, 2026
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamRoomConnectionNotInitialized, "StreamRoom connection not initialized", 0x0020) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamHandleNotInitialized, "StreamHandle not initialized", 0x0021) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamIsPublished, "Stream is published", 0x0022) | ||
| DECLARE_ENDPOINT_EXCEPTION(EndpointStreamException, StreamAlreadyPublishedException, "Stream is published", 0x0022) |
Member
There was a problem hiding this comment.
description should be: "Stream is already published" as mentioned erlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.