fix(streaming): ICE trickle serialisation, kind propagation, DataChan…#164
Draft
imaTik0 wants to merge 1 commit intorefactor/layer-boundariesfrom
Draft
fix(streaming): ICE trickle serialisation, kind propagation, DataChan…#164imaTik0 wants to merge 1 commit intorefactor/layer-boundariesfrom
imaTik0 wants to merge 1 commit intorefactor/layer-boundariesfrom
Conversation
…nelCryptor ICE trickle candidate serialisation (StreamApiNative): - Replace JSON.stringify(candidate) with serializeCandidate() which explicitly reads all 15 RTCIceCandidate fields; toJSON() only emits 4 fields causing bridge-side parse failures for candidates with extension fields RTCRtpScriptTransform kind propagation (WebRtcClient): - Pass kind: track.kind to every encode/decode transform option so the worker selects the correct header-size table (audio=1B, video key=10B, delta=3B) instead of always defaulting to video; fixes silent audio encryption DataChannelCryptor: - Use getEncryptionExternalKeyId() for the wire key ID and resolveKeyId() when passing to CryptoFacade; separates wire format from internal registry key - Extract GCM_TAG_LENGTH_BYTES = 16 named constant (was magic number) - Move Logger to class field (avoids per-call allocation) - Rename keyId → externalKeyId throughout for clarity - Add JSDoc on encrypt/decryptFromWireFormat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nelCryptor
ICE trickle candidate serialisation (StreamApiNative):
RTCRtpScriptTransform kind propagation (WebRtcClient):
DataChannelCryptor: