feat: collect and expose external category information#87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a difference between the internal category (relevant for example for dispatching) and the external category (relevant for passengers). Internally, each category follows a strict pattern of 3 letters, that uniquely represent which type of train, locomotive etc. is being used. The external category does not carry such information, but tells the passenger what type of service to expect. For example, an interregio from warsaw to lodz might use the internal category "RPJ" (indicating a regional express using an EMU), while the external category is "IR", easily recognizable by passengers.
Along with this patch comes improved parsing of the train name provided by the upstream api, also allowing for better recognition of the line & label of a journey.