Skip to content

Update Turkish chars#42

Open
tutkun wants to merge 2 commits intosindresorhus:mainfrom
tutkun:main
Open

Update Turkish chars#42
tutkun wants to merge 2 commits intosindresorhus:mainfrom
tutkun:main

Conversation

@tutkun
Copy link

@tutkun tutkun commented Feb 9, 2026

This is updating some Turkish chars.

@sindresorhus
Copy link
Owner

Thanks for the PR.

Unfortunately, this can't be merged as-is. The main problem is that adding ö→o and ü→u to replacements.js overwrites the existing global defaults (ö→oe, ü→ue), which would be a breaking change for all users, not just Turkish.

The Turkish-specific mappings for ö and ü already work correctly via locale-replacements.js when using {locale: 'tr'}.

Most of the other additions to replacements.js are duplicates of entries that already exist in the Latin section (â, Â, î, Î, û, Û, ç, Ç, etc.), so they're no-ops.

Similarly, the additions to locale-replacements.js for chars that already have the same mapping in the defaults (ç→c, ğ→g, ı→i, ş→s) are redundant.

@tutkun
Copy link
Author

tutkun commented Feb 19, 2026

Oh, sorry. I didn't know that. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants