pin the output consumer teardown fix - #103
Merged
Merged
Conversation
Adopt the reviewed SwiftTerm callback-box fix for mature-output terminal teardown without changing the Mac integration or other dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The dependency revisions are consistent, the fix is targeted, and project validation passes.
Pull request overview
Pins SwiftTerm’s output-consumer teardown fix to prevent stack growth when closing busy terminals.
Changes:
- Updates the SwiftTerm dependency revision.
- Synchronizes the resolved dependency lockfile.
File summaries
| File | Description |
|---|---|
Package.swift |
Pins the corrected SwiftTerm commit. |
Package.resolved |
Records the same resolved revision. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve current main while adopting the canonical merged output-consumer correction. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sirfergy
marked this pull request as ready for review
September 2, 2026 02:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a busy terminal after sustained output could overflow SwiftTerm's reader-thread stack. Pin the merged correction that stops output-consumer callbacks accumulating invocation wrappers without changing the delivery API or FIFO policy.
Coordination
Pins canonical fork-main merge
18de4c63fb5637d1a3d2ada17951f872682b329dfrom the merged SwiftTerm correction. Its source tree is identical to the fully reviewed and tested head; the upstream API proposal carries the same callback correction.Validation
Normal remote checkout: debug and optimized release target builds and 187 combined terminal, remote-contract, and notification tests passed. The fork's actual-adapter and small-stack teardown regressions cover sustained output and terminal close.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com