Draft
Conversation
- Move cmake/CMakePresets.json to project root - Add parameterized pixi tasks: configure, build, test, clean - Delete Makefile (pixi tasks replace all Make targets) - Update CI workflows to use `pixi run build` instead of `make` - Rewrite pixi_activate.sh for new CMakePresets location - Add clangxx dependency for C++ compiler - Change .gitmodules duckdb ignore from dirty to untracked Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mbrobbel
added a commit
to mbrobbel/sirius
that referenced
this pull request
Mar 10, 2026
Revert fmt/spdlog compat (sirius-db#430), pre-commit autofix (sirius-db#431), and pixi tasks refactor (sirius-db#432) from this branch so the vcpkg PR only contains vcpkg build support changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
# Conflicts: # pixi.toml
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The `environments` parameter alone installs but doesn't activate the env into the shell, so tools like unzip/wget from pixi deps are not available in subsequent run steps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…kills - Update CLAUDE.md, docs/README.md, test READMEs to use `pixi run build/test/clean` - Update all .claude/skills/ files to use pixi task commands - Remove docker/ directory (no longer supported, pixi replaces it) - Remove docs/NEXT_README.md and docs/UPDATING.md (DuckDB extension template leftovers) - Simplify docs/README.md: clearer requirements, build presets, one-step dataset setup - Fix pixi.toml build task inputs: broaden header globs, add missing test/**/*.hpp Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add `pixi run duckdb` to launch DuckDB CLI with Sirius (auto-rebuilds) - Add `pixi run sql-test [filter]` for SQL logic tests - Add `pixi run unittest [filter]` for C++ unit tests - Remove unused `filter` arg from `test` task - Remove Ubuntu requirement from docs (any Linux works with pixi) - Remove vCPU recommendation from docs - Update all docs to reference new task names Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joosthooz
reviewed
Mar 13, 2026
Collaborator
joosthooz
left a comment
There was a problem hiding this comment.
This is really great, I just have 2 small questions, happy to approve but this might need a green light from @bwyogatama
| "test/sql/**/*", | ||
| ] | ||
|
|
||
| [tasks.test] |
Collaborator
There was a problem hiding this comment.
Am I mistaken or is this command missing in the documentation? What does it do?
Member
Author
There was a problem hiding this comment.
It's there: test pixi run test [preset] Run ctest
| [feature.cuda12.activation.env] | ||
| # GPU architectures: Turing through Hopper (75, 80, 86, 90a) | ||
| CUDAARCHS = "75-real;80-real;86-real;90a-real" | ||
| [feature.cuda12] |
Collaborator
There was a problem hiding this comment.
We state cuda > 13 as a requirement, do we still want to keep 12 support?
Member
Author
There was a problem hiding this comment.
We used this to support older drivers, I think there is no harm in keeping it. Once we have a better runner setup we can add a cuda 12 job.
# Conflicts: # docs/README.md # pixi.lock # pixi.toml
# Conflicts: # Makefile # docs/README.md
# Conflicts: # docs/README.md
…oval Update documentation to use `pixi run build`, `pixi run duckdb`, `pixi run unittest`, and `pixi run sql-test` instead of `make` and raw binary paths, consistent with the pixi task refactor. Files updated: - docs/gpu_execution.md - docs/gpu_processing.md - docs/DEVELOPMENT.md (CMakePresets.json path) - test/tpch_performance/CLAUDE.md - test/tpch_performance/run.md - .claude/skills/config-optimizer/SKILL.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
792ebbc to
da99b4a
Compare
Resolve conflicts: - check.yml: adopt upstream's CI matrix (nightly, compiler/build-type) with pixi tasks instead of make - pixi.toml: keep pixi tasks, add upstream's cuda feature deps, move libcudf to feature deps, relax libabseil pin - pixi.lock: regenerated with clangxx addition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7382c0b to
8e19927
Compare
Three issues in generate_nightly_env.sh: - Channel sed pattern had trailing space preventing rapidsai-nightly swap - Single-line deletion of [feature.nightly-runner] left orphaned `pixi = "*"` that broke TOML parsing; use range-based deletion instead - Add `cwd = "../.."` to generated tasks so cmake runs from repo root (pixi sets cwd to manifest parent, which is envs/nightly/) Also fix pixi_activate.sh to resolve repo root via BASH_SOURCE instead of PIXI_PROJECT_ROOT, which points to envs/nightly/ for the nightly env. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- .claude/commands/test.md: pixi run make → pixi run build/sql-test/unittest - .claude/skills: EXTRA_CMAKE_FLAGS env var doesn't work with pixi tasks; use pixi shell + manual cmake for sanitizer builds instead - docs/gpu_processing.md: pixi run build would re-configure without the legacy flag; use pixi shell + manual cmake - profile_tpch_nsys.sh: stale make reference in error message Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefilewith pixi tasks inpixi.tomlfor all build/test/run operationsduckdb(launch CLI),sql-test(SQL logic tests),unittest(C++ unit tests)depends-onandinputspixi run buildinstead ofmakedocker/directory (no longer supported, pixi replaces it)NEXT_README.md,UPDATING.md)inputs: broaden header globs (src/**/*.hpp), addtest/**/*.hppPixi tasks
buildpixi run build [preset]duckdbpixi run duckdb [preset]sql-testpixi run sql-test [preset] [filter]unittestpixi run unittest [preset] [filter]testpixi run test [preset]cleanpixi run clean [preset]configurepixi run configure [preset]Test plan
pixi run buildbuilds successfullypixi run duckdblaunches DuckDB with Siriuspixi run sql-testruns SQL logic testspixi run unittestruns C++ unit tests🤖 Generated with Claude Code