feat: aarch64 build support for Doris integration layer#599
Draft
bwyogatama wants to merge 1 commit intodorisfrom
Draft
feat: aarch64 build support for Doris integration layer#599bwyogatama wants to merge 1 commit intodorisfrom
bwyogatama wants to merge 1 commit intodorisfrom
Conversation
- pixi.toml: platform-conditional sysroot (linux-64/linux-aarch64), arch-detecting CUDA target paths (sbsa-linux/x86_64-linux), dynamic LD_LIBRARY_PATH for sirius-be tasks, RUSTFLAGS in doris-build for aarch64 lib search path - doris/crates/nixl-test/build.rs: cfg\!(target_arch) for CUDA stubs path All x86_64 behavior preserved via else/|| branches. No third-party submodule modifications required. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
165b952 to
c14c406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sysroot_linux-aarch64for ARM,sysroot_linux-64for x86), arch-detecting CUDA target paths (sbsa-linux/x86_64-linuxviauname -m), dynamicLD_LIBRARY_PATHfor bothsirius-betasks, andRUSTFLAGSindoris-buildfor aarch64 lib search pathcfg\!(target_arch = "aarch64")detection for CUDA stubs path (sbsa-linuxvsx86_64-linux)No third-party submodule modifications. The nixl-sys hardcoded
x86_64-linux-gnulib path is worked around by adding the correct arch-specific path viaRUSTFLAGSin the build task.All changes preserve exact x86_64 behavior via
else/||branches that produce the original hardcoded values.Test plan
pixi install -e dorison aarch64 — confirmsysroot_linux-aarch64resolvespixi run -e doris doris-buildon aarch64 — confirm cargo build succeeds, nixl links correctlypixi run -e doris sirius-beon aarch64 — confirm BE starts without missing library errorstomllib.load)sbsa-linux,aarch64-linux-gnu)x86_64-linuxpaths remain in CUDA meson flagsenv = { LD_LIBRARY_PATH }blocks remain (dynamic detection instead)🤖 Generated with Claude Code