Conversation
WiredSpast
left a comment
There was a problem hiding this comment.
The included zip file appears to be invalid as well
| @@ -0,0 +1,17 @@ | |||
| # G-EnterFullRoom | |||
There was a problem hiding this comment.
Don't put any other files except the permitted/mandatory files into the folder.
Permitted/mandatory files:
- extension.json (mandatory)
- extension.zip (mandatory)
- icon.png (permitted)
- screenshot.png (permitted)
| "version": "1.0", | ||
| "categories": ["Usability", "Others"], | ||
|
|
||
| "source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/", |
There was a problem hiding this comment.
The source repository must be a repository with the open source code, not your own fork of the store repository (Same for the readme)
|
|
||
| "source": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/", | ||
| "readme": "https://github.com/HabboMaik/G-ExtensionStore/blob/repo/1.5.2/store/extensions/G-EnterFullRoom/README.md", | ||
| "releases": "" |
There was a problem hiding this comment.
Remove it if you're not adding a releases page
| "framework": { | ||
| "name": "Geode", | ||
| "version": "1.5" | ||
| }, | ||
|
|
||
| "language": "Java", | ||
| "commands": { | ||
| "default": ["java", "-jar", "GClick.jar", "-c", "{cookie}", "-p", "{port}", "-f", "{filename}"], | ||
| "linux": ["(optional) <some OS-specific command...>"] | ||
| }, |
There was a problem hiding this comment.
The framework used is listed as Geode but the language is listed as Java, since Geode is a .NET language this isn't possible, also remove the linux command if it's not different from the default
There was a problem hiding this comment.
I hope its right after changes..
|
|
||
| "source": "https://github.com/HabboMaik/G-EnterFullRoom", | ||
| "readme": "https://github.com/HabboMaik/G-EnterFullRoom/blob/main/README.md", | ||
| "releases": "https://github.com/HabboMaik/G-EnterFullRoom/releases/tag/v1.0" |
There was a problem hiding this comment.
hmm can you remove the /tag/v1.0? I think the releases field is meant to be non-version specific
|
|
||
| "compatibility": { | ||
| "systems": ["Linux", "Windows", "Mac"], | ||
| "clients": ["Unity", "Flash"] |
There was a problem hiding this comment.
You're sure this one works for unity too?
|
https://github.com/HabboMaik/G-EnterFullRoom doesn't seem to be source code, but rather the executable files in the repository |
| "framework": { | ||
| "name": "Geode", | ||
| "version": "1.5" | ||
| }, |
There was a problem hiding this comment.
According to my decompiler the Geode version which was used is 1.4.1.0 not 1.5
| "framework": { | |
| "name": "Geode", | |
| "version": "1.5" | |
| }, | |
| "framework": { | |
| "name": "Geode", | |
| "version": "1.4.1.0" | |
| }, |
| "systems": ["Linux", "Windows", "Mac"], | ||
| "clients": ["Unity", "Flash"] |
There was a problem hiding this comment.
As far as I now Geode extensions only work on Windows
Geode also only works for Flash (unless you specify the header ids yourself, but I don't think you did)
|
One major other thing: The version of Geode you're using appears to be quite outdated, it doesn't take port, cookie and file arguments, these are required for the store |
Co-authored-by: WiredSpast <74211155+WiredSpast@users.noreply.github.com>
Co-authored-by: WiredSpast <74211155+WiredSpast@users.noreply.github.com>
@WiredSpast maybe you know how to update the Geode / can help me maybe? |
K, thank you. I changed the .dll file. I hope everything is fine now! :) |
|
Woops I made that reply on the wrong account
Try running the extension, I doubt it will work right away since there have been some major changes in the mean time |
Oh yeah, it doesnt work anymore.. But thanks for yall help! :\ |
No description provided.