refactor(cli): redesign skip grouping in console output#444
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors Pivot’s console output for skipped stages by replacing the old threshold-based collapsing with consistent, category-aware grouping, improving readability and consistency in both static and live console sinks.
Changes:
- Collapses 2+ consecutive skipped stages only when they share the same category (cached/blocked/cancelled), removing the previous 20-stage threshold.
- Updates skip-group formatting to include category-specific labels (e.g., “3 cached”) and dims individual skip lines for consistent visual weight.
- Refreshes and expands sink tests to cover single-skip behavior, same-category collapsing, and category boundary cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/pivot/src/pivot/engine/sinks.py | Implements same-category skip grouping (2+ collapses), category-labeled group lines, and dimmed single-skip output. |
| packages/pivot/tests/engine/test_sinks.py | Updates existing assertions and adds/adjusts tests to match the new grouping + labeling behavior. |
| docs/plans/2026-02-13-skip-grouping-redesign.md | Adds an implementation plan documenting the intended behavior and test changes. |
Replace threshold-based skip collapsing with consistent category-aware grouping:
- Always collapse 2+ consecutive same-category skips (removed 20-stage threshold)
- Split groups by category: cached, blocked, cancelled get separate lines
- Label groups with actual reason ('3 cached') instead of generic 'not run'
- Dim single skip stage lines for consistent visual weight with collapsed groups
199e8f9 to
a1fafe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the threshold-based skip collapsing (>20 consecutive → collapse) with consistent category-aware grouping:
Before
After
Design doc:
docs/plans/2026-02-13-skip-grouping-redesign.md