Add fair node exit command for removing nodes from fair manager contracts#897
Closed
Add fair node exit command for removing nodes from fair manager contracts#897
Conversation
Co-authored-by: dmytrotkk <15244591+dmytrotkk@users.noreply.github.com>
Collaborator
|
@copilot do not add a new blueprint, |
Copilot
AI
changed the title
[WIP] Add remove fair node command
Add fair node exit command for removing nodes from fair manager contracts
Aug 1, 2025
Author
Refactored the command structure as requested. Removed the complex blueprint hierarchy and moved the command to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
fair node exit --yescommand to remove nodes from fair manager smart contracts as requested in issue #896.Implementation
The new command follows the established CLI patterns and integrates seamlessly with the existing node-cli infrastructure:
skale fair node exit --yesKey Features
/api/v1/fair/node/exitendpoint--yesconfirmation flag to prevent accidental executionset-domain-name@check_initeddecorator to ensure node is properly initialized@streamed_cmddecorator for consistent output handlingArchitecture
The implementation follows the established three-layer pattern:
node_cli/cli/fair.py): Command hierarchyfair→node→exitnode_cli/core/fair.py): API call handling usingpost_requesthelpernode_cli/configs/routes.py): Addedfair/node/exitto API routesResponse Handling
The command provides clear feedback:
Node successfully removed from fair manager contractsCLIExitCodes.BAD_API_RESPONSEand displays error messageTesting
Comprehensive test coverage includes:
run_command_mockhelperThe implementation maintains the codebase's style guidelines with no comments and clean, readable code that matches existing command patterns.
Fixes #896.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.