Closed
Conversation
Function doesn't wait for `openssl s_client ...` to finish. It assumes that when the command is still running that is the successful condition. However the function should wait for exit code from the binary. We saw in production intermittent and very often `skale ssl upload` failures. This change should fix this problem and underlying race condition.
Replace for loop and dp.poll() with more straightforward dp.wait() with a timeout, as requested during diff review.
Redirect the child's standard input to subprocess.DEVNULL, so it starts with no stdin attached. This prevents the OpenSSL health-check process from reading from, or blocking on, the parent's terminal or execution environment stdin stream.
Fix check_ssl_connection() function
Remove docker-compose requirement
Co-authored-by: dmytrotkk <15244591+dmytrotkk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add remove fair node command
Add fair node exit command
Aug 1, 2025
Collaborator
|
@copilot new base branch is |
Author
Updated the PR to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
fair node exit --yescommand to remove nodes from fair manager contracts as requested.Implementation Details
The command follows the exact syntax specified:
skale fair node exit --yesThe implementation includes:
New CLI module (
node_cli/cli/fair.py) with proper command hierarchy:fairgroup commandnodesubgroup under fairexitcommand with--yesconfirmation flagCore functionality (
node_cli/core/fair.py) that:/api/v1/fair/node/exitrouteerror_exit()API route configuration added to
routes.pyfor the fair node removal endpointComprehensive test suite (
tests/cli/fair_test.py) with mocked scenarios:Code Quality
The implementation follows the existing codebase patterns:
@check_inited,@streamed_cmd)All tests pass successfully and the command integrates seamlessly with the existing CLI structure.
Fixes #896.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.