fix: use core.setFailed() instead of throw Error() in find-exercise-issue workflow#117
Merged
FidelusAleksander merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
…ssue workflow Co-authored-by: FidelusAleksander <63016446+FidelusAleksander@users.noreply.github.com>
FidelusAleksander
approved these changes
Mar 3, 2026
FidelusAleksander
approved these changes
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the find-exercise-issue workflow’s error handling to fail the GitHub Actions step cleanly (without an “Unhandled error”) when no matching exercise issue is found.
Changes:
- Replaced
throw new Error(...)withcore.setFailed(...)for missing-issue handling - Added an early
returnafter setting the failure state to stop further script execution
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The find-exercise-issue workflow was throwing unhandled errors when no exercise issue was found, resulting in GitHub Actions displaying "Error: Unhandled error: Error: No exercise issue found."
Changed error handling in
.github/workflows/find-exercise-issue.ymlto usecore.setFailed()instead ofthrow new Error():This matches the pattern used elsewhere in the codebase (e.g.,
actions/file-exists/action.yml) and ensures proper error formatting in GitHub Actions.Checklist