fix: remove a conditional that prevented image url updates for repositories created from private repository templates#125
Merged
FidelusAleksander merged 1 commit intomainfrom Mar 24, 2026
Conversation
Removed conditional check for template repository before finding and replacing image URLs.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a workflow step guard so that the image URL replacement in .github/steps/*.md always runs, ensuring repositories created from private templates still get updated image links.
Changes:
- Removed the
if:condition that skipped the “Find and replace image URLs in step files” step whenTEMPLATE_REPOSITORYoutput was empty.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lilili14333
reviewed
Mar 23, 2026
Lilili14333
left a comment
Lilili14333
left a comment
There was a problem hiding this comment.
Changes
Checklist
I have added or updated appropriate labels to this PR
I have tested my changes
I have updated the documentation if needed
arilivigni
approved these changes
Mar 23, 2026
|
🥰🥰🥰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the workflow configuration by removing a conditional check from the "Find and replace image URLs in step files" job step. This simplifies the workflow and ensures that the step always runs, regardless of the template repository output.
Changes
Checklist