WIP: Properly handle dead key shortcuts#10891
Draft
LeonMatthes wants to merge 1 commit intoslint-ui:masterfrom
Draft
WIP: Properly handle dead key shortcuts#10891LeonMatthes wants to merge 1 commit intoslint-ui:masterfrom
LeonMatthes wants to merge 1 commit intoslint-ui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning, this is still a work in progress. I have noticed that, for example, Qt on Linux when pressing control actually provides a different key code for the dead keys, which is apparently due to some XKB convention.
The seems to mostly work on winit, but winit only produces pressed events, not released events when dead keys are involved.
So this will require more work and especially unification across our back ends.
@tronical We should discuss what the expected behavior in Slint is here and whether we even want to expose dead keys as normal key events or whether they need some kind of special handling.