Android: Fix cursor position when setting from popup by Murmele · Pull Request #11003 · slint-ui/slint

Murmele · 2026-03-13T08:04:14Z

Under Android the popup is not a dedicated window with own coordinate system, but only a ChildWindow of the main window. Because of that the position of the popup must be considered as well, because everything is relative to the main window

Fixes: #10475

The testcase popupwindow_nested.slint checks if the changes are correct

Reason: If not a dedicated window, it does not have its own coordinate system, but all elements must be still relative to the main window. Fixes: slint-ui#10475

…root index instead of hardcoded 0

This reverts commit 068ea52. #Conflicts: # internal/backends/android-activity/javahelper.rs # internal/core/item_tree.rs # internal/core/items/text.rs # internal/core/window.rs

Replace the hardcoded `ROOT_ITEM_INDEX` constant with a new `ItemRc::new_root` method and `is_root` check

…opup' #Conflicts: # internal/core/item_tree.rs

…ant logic Remove redundant code that calculates `parent_window_adapter` and `position` for popup placement, as this is already handled in the mapping function. The logic was duplicated and unnecessary, reducing code complexity and improving readability. This change aligns with the existing mapping logic that already determines the correct window adapter and position for popups.

…opup'

internal/core/window.rs

Reason: Otherwise it might be that for TopLevel Windows the position is incorrect

Murmele · 2026-03-16T08:13:22Z

I am wondering where the logic for the mouse position is ...

ogoffart

This change the behavior of map_to_window to no longer stop at the PopupWindow but return the value of the actual Window.
This will indeed solve the bug. I wonder if it won't have unintended side effect. (Like will it change the behavior of the absolute-position property?)

Just a comment for next time:
The drive-by refactoring of ItemRc is great, but makes the change harder to review because that is most of the content of the change, and the commit history is not clean enough to allow per-commit review. In that case, it is helpful to rebase -i the change to keep a clean commit history, or put it in a separate PR.

ogoffart · 2026-03-17T07:51:16Z

internal/core/item_tree.rs

 use crate::slice::Slice;
 use crate::window::WindowAdapterRc;
 use alloc::vec::Vec;
+use core::borrow::Borrow;


In my experience, this gets added by rust_analyzer sometimes when trying to borrow something that is not a RefCell. Are you sure you really mean to add this?

Reverted in 54d4f28

ogoffart · 2026-03-17T08:29:25Z

internal/core/item_tree.rs

            .is_none_or(|adapter| adapter.renderer().supports_transformations());
        while let Some(parent) = current.parent_item(ParentItemTraversalMode::StopAtPopups) {
            if stop_condition(&parent) {
                break;


Suggested change

return result;

I believe we don't want to add the popup position when we are called from the map_to_item_tree function.

(Alternative would be to move the added code directly in map_to_window)

reverted because not required because of 4450eda

#Conflicts: # internal/backends/winit/accesskit.rs # internal/core/window.rs

Murmele · 2026-03-18T17:35:07Z

One thing I don't understand yet is why in the test absolute_coords.slint does not trigger https://github.com/Murmele/slint/blob/mm/android_cursor_popup/internal/core/item_tree.rs#L614
It jumps into and checks the if condition but it is never fullfilled. @ogoffart do you have an idea why?
Ah it is probably because they don't have the same itemtree because of the dynamic if condition?

is_root_item_of() does not consider dynamic elements

…opup'

Reason: because map_to_window is used for logical mapping to the window but sometimes we really need the screen value if the popup is only virtual

ogoffart · 2026-03-19T07:40:34Z

internal/core/item_tree.rs

        &self,
        p: LogicalPoint,
        stop_condition: impl Fn(&Self) -> bool,
+        consider_popup: bool,


Inside of passing a boolean there that is only true in map_to_screen, just move the code that consider the popup in the map_to_screen function.

done in 4450eda

ogoffart · 2026-03-19T07:42:36Z

internal/core/item_tree.rs

+    /// Similar to `map_to_window` but considers also the popup location if the popup
+    /// is not a dedicated window but of type ChildWindow
+    /// Use this function if you wanna have the real absolute position
+    pub fn map_to_screen(&self, p: LogicalPoint) -> LogicalPoint {


map_to_screen here is not the right name, because this is not the case when the top level window is not full screen (eg, on desktop)

A better name would perhaps be map_to_native_window

done in 4450eda

…ap_to_native_window function

internal/core/item_tree.rs

Was unintentionally

Murmele force-pushed the mm/android_cursor_popup branch from 3f88b57 to 5889c9a Compare March 13, 2026 08:35

Murmele added 2 commits March 13, 2026 09:37

Debug

068ea52

Fix mapping if the popup is not a dedicated window

85c9db7

Reason: If not a dedicated window, it does not have its own coordinate system, but all elements must be still relative to the main window. Fixes: slint-ui#10475

Murmele force-pushed the mm/android_cursor_popup branch from 849ccad to 85c9db7 Compare March 13, 2026 08:44

Fix checking if the component is in a popup and use constant for the …

fa0c5ce

…root index instead of hardcoded 0

Murmele force-pushed the mm/android_cursor_popup branch from 66a5a84 to fa0c5ce Compare March 13, 2026 13:43

autofix-ci bot and others added 7 commits March 13, 2026 13:45

[autofix.ci] apply automated fixes

66ccebd

Revert "Debug"

7241a9d

This reverts commit 068ea52. #Conflicts: # internal/backends/android-activity/javahelper.rs # internal/core/item_tree.rs # internal/core/items/text.rs # internal/core/window.rs

[autofix.ci] apply automated fixes

917fafd

introduce ItemRc::new_root and remove hardcoded root index

5aa83e3

Replace the hardcoded `ROOT_ITEM_INDEX` constant with a new `ItemRc::new_root` method and `is_root` check

Merge remote-tracking branch 'refs/remotes/origin/mm/android_cursor_p…

377754e

…opup' #Conflicts: # internal/core/item_tree.rs

[autofix.ci] apply automated fixes

a69ca94

add comment

8384be8

Murmele changed the title ~~Mm/android cursor popup~~ Android: Fix cursor position when setting from popup Mar 13, 2026

Murmele added 3 commits March 13, 2026 16:13

Merge remote-tracking branch 'refs/remotes/origin/mm/android_cursor_p…

10d9740

…opup'

remove not needed calculation

c6a70ab

Murmele commented Mar 13, 2026

View reviewed changes

internal/core/window.rs Show resolved Hide resolved

Murmele requested a review from ogoffart March 13, 2026 15:37

revert logic for determination of the popup location

4228834

Reason: Otherwise it might be that for TopLevel Windows the position is incorrect

Murmele marked this pull request as ready for review March 16, 2026 08:12

ogoffart reviewed Mar 17, 2026

View reviewed changes

Murmele marked this pull request as draft March 17, 2026 09:08

Murmele added 6 commits March 18, 2026 08:33

Merge remote-tracking branch 'refs/remotes/upstream/master'

dd04e1e

#Conflicts: # internal/backends/winit/accesskit.rs # internal/core/window.rs

remove not needed use

772c634

WIP

e2ff728

WIP

2530a01

WIP

94fa6bc

Update item_tree.rs

d5fc651

Murmele added 3 commits March 18, 2026 16:05

WIP

28e23a9

WIP

077f2bf

add check if ChildWindow popup

e6e818e

Murmele and others added 8 commits March 18, 2026 18:37

fix clippy

7035d47

add additional test

c8fd702

[autofix.ci] apply automated fixes

02645b6

fix

8d1d3f4

Merge remote-tracking branch 'refs/remotes/origin/mm/android_cursor_p…

3ff4c0c

…opup'

cleanup test

eda0493

introduce map_to_screen

885c7f3

Reason: because map_to_window is used for logical mapping to the window but sometimes we really need the screen value if the popup is only virtual

add test with dynamic element

36abdb5

ogoffart reviewed Mar 19, 2026

View reviewed changes

Murmele added 3 commits March 19, 2026 09:14

the popup logic is used only once so we can have it directly in the m…

4450eda

…ap_to_native_window function

fix test

3f20ff6

remove not needed borrow

54d4f28

Murmele commented Mar 19, 2026

View reviewed changes

internal/core/item_tree.rs Outdated Show resolved Hide resolved

Murmele and others added 5 commits March 19, 2026 11:27

No need to specify type

bb17aa4

Was unintentionally

fix on android

8a7ade1

fix compilation

37698b3

Fix clippy

76590c0

fix cpp tests

e7abea3

Murmele marked this pull request as ready for review March 19, 2026 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android: Fix cursor position when setting from popup#11003

Android: Fix cursor position when setting from popup#11003
Murmele wants to merge 39 commits intoslint-ui:masterfrom
Murmele:mm/android_cursor_popup

Murmele commented Mar 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Murmele commented Mar 16, 2026

Uh oh!

ogoffart left a comment

Uh oh!

ogoffart Mar 17, 2026

Uh oh!

Murmele Mar 19, 2026

Uh oh!

ogoffart Mar 17, 2026

Uh oh!

Murmele Mar 19, 2026

Uh oh!

Murmele commented Mar 18, 2026 •

edited

Loading

Uh oh!

ogoffart Mar 19, 2026

Uh oh!

Murmele Mar 19, 2026

Uh oh!

ogoffart Mar 19, 2026

Uh oh!

Murmele Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Murmele commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Murmele commented Mar 16, 2026

Uh oh!

ogoffart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Murmele commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Murmele commented Mar 13, 2026 •

edited

Loading

Murmele commented Mar 18, 2026 •

edited

Loading