Skip to content

Conversation

@savely-krasovsky
Copy link

@savely-krasovsky savely-krasovsky commented Jan 5, 2026

Name of feature:

Unset OnlyContainsUserCerts and OnlyContainsCACerts options during Distribution Point marshaling.

Pain or issue this feature alleviates:

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jan 5, 2026
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried, but my I think that if you set idpOnlyContainsCACerts and you revoke a "user" certificate, that will also appear in the CRL.

@savely-krasovsky
Copy link
Author

If there is no special reason to set OnlyUser I think it would make sense to just disable it. Specification says you must set either distribution point or one of those flags on, but in our case DP is already set, so both flags could be unset.

@savely-krasovsky
Copy link
Author

@maraino what do you think about the change like that? I don't see any particular reason why those params are set. step-ca CRL list could contain both CA and user certs.

@savely-krasovsky savely-krasovsky changed the title feat: add options to configure CRL IDP flags feat: unset OnlyContainsUserCerts and OnlyContainsCACerts options during Distubution Point marshaling Jan 7, 2026
@savely-krasovsky savely-krasovsky changed the title feat: unset OnlyContainsUserCerts and OnlyContainsCACerts options during Distubution Point marshaling feat: unset OnlyContainsUserCerts and OnlyContainsCACerts options during Distribution Point marshaling Jan 7, 2026
@maraino
Copy link
Contributor

maraino commented Jan 7, 2026

@maraino what do you think about the change like that? I don't see any particular reason why those params are set. step-ca CRL list could contain both CA and user certs.

That makes more sense to me, we'll include this in our next triage.

@maraino maraino self-requested a review January 7, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants