Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new ODBC end-to-end coverage for SQLColAttribute (ODBC 3.x) and SQLColAttributes (ODBC 2.x), including spec-driven success paths and key error cases, and wires the new tests into the existing ODBC test/feature validation workflow.
Changes:
- Introduces new Gherkin feature definitions for
SQLColAttributeandSQLColAttributes. - Adds Catch2 E2E implementations for both APIs, including a documented behavior difference for ODBC 2.x alias handling via
SQLColAttribute. - Registers the new tests in
odbc_tests/tests/e2e/CMakeLists.txtand documents BD#22 inBehaviorDifferences.yaml.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/definitions/odbc/query/sql_col_attributes.feature |
New feature spec scenarios for ODBC 2.x SQLColAttributes. |
tests/definitions/odbc/query/sql_col_attribute.feature |
New feature spec scenarios for ODBC 3.x SQLColAttribute (incl. truncation + error cases). |
odbc_tests/tests/e2e/query/sql_col_attributes.cpp |
New Catch2 E2E tests implementing the SQLColAttributes feature scenarios. |
odbc_tests/tests/e2e/query/sql_col_attribute.cpp |
New Catch2 E2E tests implementing the SQLColAttribute feature scenarios (incl. BD#22 gating). |
odbc_tests/tests/e2e/CMakeLists.txt |
Adds the two new query E2E test targets. |
odbc_tests/BehaviorDifferences.yaml |
Adds BD#22 documenting old vs new driver behavior for ODBC 2.x field aliases via SQLColAttribute. |
.cursor/rules/odbc-test-generation.mdc |
Updates contributor workflow guidance for handling old/new driver behavior differences. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+228
to
240
| 22: | ||
| name: "SQLColAttribute does not reliably support ODBC 2.x field aliases through the 3.x function" | ||
| description: | | ||
| OLD driver: When SQLColAttribute (ODBC 3.x) is called with ODBC 2.x field | ||
| identifiers (SQL_COLUMN_NAME, SQL_COLUMN_TYPE, etc.), the old driver | ||
| exhibits inconsistent behavior — returning empty strings, incorrect values, | ||
| or HY091 errors depending on the identifier. | ||
| NEW driver: Properly maps ODBC 2.x field identifiers to their SQL_DESC_* | ||
| equivalents per the ODBC specification backward compatibility rules. | ||
| Impact: Applications using ODBC 2.x field identifiers with the 3.x function | ||
| will now receive correct values. | ||
|
|
||
| 26: |
| ## Validation Workflow (MANDATORY) | ||
|
|
||
| 1. **Validate against OLD driver first** using `odbc_tests/run_reference.sh -R <test_suite_name>` | ||
| - If tests doesn't pass on old driver add behavior difference in odbc_tests/BehaviorDifferences.yaml and use OLD_DRIVER_ONLY, NEW_DRIVER_ONLY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.