SNOW-3243341: optional dependencies in cursor (pyarrow, pandas)#639
Open
sfc-gh-asolarski wants to merge 2 commits intomainfrom
Open
SNOW-3243341: optional dependencies in cursor (pyarrow, pandas)#639sfc-gh-asolarski wants to merge 2 commits intomainfrom
sfc-gh-asolarski wants to merge 2 commits intomainfrom
Conversation
This was referenced Mar 19, 2026
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
b00072e to
a2458e8
Compare
sfc-gh-asolarski
changed the title
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
a2458e8 to
a722309
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
from
3201d1d to
fa645ee
Compare
This was referenced Mar 20, 2026
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
from
fa645ee to
5469b66
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
a722309 to
4d0bc36
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
4d0bc36 to
b4692bf
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
2 times, most recently
from
7e3c6db to
075543b
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
b4692bf to
ce4fb08
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
from
075543b to
905880c
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
ce4fb08 to
1e58685
Compare
sfc-gh-turbaszek
requested changes
Mar 23, 2026
Comment on lines
+828
to
+832
| msg = ( | ||
| "Optional dependency: 'pyarrow' is not installed, please see the following link for" | ||
| " install instructions: https://docs.snowflake.com/en/user-guide/python-connector-pandas.html#installation" | ||
| ) | ||
| raise ProgrammingError(msg=msg, errno=ER_NO_PYARROW) |
Contributor
There was a problem hiding this comment.
Isn't the message produced already in MissingOptionalDependency? If we have MissingPyarrow class it would be good to put all logic related to handling of it there . Especially that both arrow and pandas follow the same logic
Contributor
Author
There was a problem hiding this comment.
I made this whole logic more generic for now.
Moved the creation of messages
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
1e58685 to
c91a26d
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
2 times, most recently
from
99ec8bc to
78f826e
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
c91a26d to
7963d70
Compare
sfc-gh-asolarski
changed the base branch from
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
to
graphite-base/639
sfc-gh-asolarski
force-pushed
the
graphite-base/639
branch
from
78f826e to
7bc43ec
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
7963d70 to
2bb35ba
Compare
sfc-gh-asolarski
changed the base branch from
graphite-base/639
to
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
sfc-gh-asolarski
changed the base branch from
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
to
graphite-base/639
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
2bb35ba to
c48200b
Compare
sfc-gh-asolarski
force-pushed
the
graphite-base/639
branch
from
7bc43ec to
883c73a
Compare
sfc-gh-asolarski
changed the base branch from
graphite-base/639
to
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
| ParamStyle, | ||
| ) | ||
| from ._internal.decorators import pep249 | ||
| from ._internal.options import check_dependency, pandas, pyarrow |
Contributor
There was a problem hiding this comment.
Suggested change
| from ._internal.options import check_dependency, pandas, pyarrow | |
| from ._internal.extras import check_dependency, pandas, pyarrow |
Given it's completely new module maybe it's worth to consider a naming that is more related to the package "extras"? WDYT?
sfc-gh-turbaszek
approved these changes
Mar 23, 2026
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_optional_dependencies_pyarrow_pandas_
branch
from
c48200b to
7ddb233
Compare
sfc-gh-asolarski
force-pushed
the
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
branch
from
883c73a to
451213d
Compare
Base automatically changed from
03-19-snow-3243341_e2e_tests_for_pyarrow_pandas_type_conversion
to
main
March 23, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.