Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the Settings LiveView UI into clearer grouped sections, while adjusting toggle/spacing behavior and updating warning color tokens used for the new “High impact” badge.
Changes:
- Make
toggle_switchlabel optional (no empty label span when omitted). - Restructure settings page into grouped sections (Display, Debugging behavior, Performance & memory) and add a “High impact” warning pill.
- Tune settings switch alignment/padding and adjust light theme warning colors (introduce
--swm-yellow-30).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/live_debugger/app/web/components.ex | Makes toggle_switch label optional and conditionally rendered. |
| lib/live_debugger/app/settings/web/settings_live.ex | Re-groups settings into sections and adds a warning badge for performance-impacting settings. |
| lib/live_debugger/app/settings/web/components.ex | Updates settings switch layout and wrapper padding. |
| assets/app/styles/themes/light.css | Tweaks warning background/border tokens for light theme. |
| assets/app/styles/colors.css | Adds --swm-yellow-30 color token used by the updated warning background. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kraleppa
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.