Skip to content

WIP commit hook improvements #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kmichalikk wants to merge 2 commits into
base: main
Choose a base branch
from
+1,255 −320
Draft

WIP commit hook improvements #3578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
475bdea
Get correct top inset when orientation changes
kmichalikk Feb 16, 2026
e593df3
Debug
kmichalikk Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions FabricExample/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import App from '../apps';
import { featureFlags } from 'react-native-screens';

featureFlags.experiment.synchronousScreenUpdatesEnabled = false
featureFlags.experiment.synchronousHeaderConfigUpdatesEnabled = false
featureFlags.experiment.synchronousHeaderSubviewUpdatesEnabled = false
featureFlags.experiment.androidResetScreenShadowStateOnOrientationChangeEnabled = true
featureFlags.experiment.synchronousScreenUpdatesEnabled = false;
featureFlags.experiment.synchronousHeaderConfigUpdatesEnabled = false;
featureFlags.experiment.synchronousHeaderSubviewUpdatesEnabled = false;
featureFlags.experiment.androidResetScreenShadowStateOnOrientationChangeEnabled =
true;
// TODO: @t0maboro - remove ts-ignore after release
// @ts-ignore - will be present since react-native-screens 4.21.0
featureFlags.experiment.iosPreventReattachmentOfDismissedScreens = false
featureFlags.experiment.iosPreventReattachmentOfDismissedScreens = false;

export default App;
7 changes: 7 additions & 0 deletions FabricExample/android/app/src/main/java/com/fabricexample/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.fabricexample

import android.content.res.Configuration
import android.os.Bundle
import android.util.Log
import com.facebook.react.ReactActivity
import com.facebook.react.ReactActivityDelegate
import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.fabricEnabled
Expand All @@ -15,6 +17,11 @@ class MainActivity : ReactActivity() {
*/
override fun getMainComponentName(): String = "FabricExample"

override fun onConfigurationChanged(configuration: Configuration) {
super.onConfigurationChanged(configuration)
Log.d("SCREENS", "activity id ${this} orientation = ${configuration.orientation}")
}

/**
* Returns the instance of the [ReactActivityDelegate]. We use [DefaultReactActivityDelegate]
* which allows you to enable New Architecture with a single boolean flags [fabricEnabled]
Expand Down
9 changes: 9 additions & 0 deletions FabricExample/android/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,12 @@ extensions.configure(com.facebook.react.ReactSettingsExtension) { ex -> ex.autol
rootProject.name = 'FabricExample'
include ':app'
includeBuild('../node_modules/@react-native/gradle-plugin')

includeBuild('../node_modules/react-native') {
dependencySubstitution {
substitute(module("com.facebook.react:react-android")).using(project(":packages:react-native:ReactAndroid"))
substitute(module("com.facebook.react:react-native")).using(project(":packages:react-native:ReactAndroid"))
substitute(module("com.facebook.react:hermes-android")).using(project(":packages:react-native:ReactAndroid:hermes-engine"))
substitute(module("com.facebook.react:hermes-engine")).using(project(":packages:react-native:ReactAndroid:hermes-engine"))
}
}
10 changes: 5 additions & 5 deletions FabricExample/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"@react-navigation/stack": "link:../react-navigation/packages/stack/",
"nanoid": "^4.0.2",
"react": "19.2.3",
"react-native": "0.84.0-rc.1",
"react-native": "0.83",
"react-native-gesture-handler": "^2.29.0",
"react-native-reanimated": "~4.2.1",
"react-native-restart": "^0.0.27",
Expand All @@ -43,10 +43,10 @@
"@react-native-community/cli": "20.1.0",
"@react-native-community/cli-platform-android": "20.1.0",
"@react-native-community/cli-platform-ios": "20.1.0",
"@react-native/babel-preset": "0.84.0-rc.1",
"@react-native/eslint-config": "0.84.0-rc.1",
"@react-native/metro-config": "0.84.0-rc.1",
"@react-native/typescript-config": "0.84.0-rc.1",
"@react-native/babel-preset": "0.83",
"@react-native/eslint-config": "0.83",
"@react-native/metro-config": "0.83",
"@react-native/typescript-config": "0.83",
"@types/jest": "^29.5.13",
"@types/react": "^19.2.0",
"@types/react-test-renderer": "^19.1.0",
Expand Down
Loading
Loading