fix(android): Fix Activity memory leak in ScreenDummyLayoutHelper due to unreleased view references and missing lifecycle cleanup#3638
Open
l2hyunwoo wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
- Convert lateinit var to nullable var for view fields - Always register LifecycleEventListener regardless of init result - Null all view references and reset state in onHostDestroy - Add synchronized block to prevent race between compute and cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #3636
Fix Activity memory leak in
ScreenDummyLayoutHelpercaused by unreleased view references (CoordinatorLayout,AppBarLayout,Toolbar,View) when the host Activity is destroyed.The helper creates dummy views using Activity-scoped
Contextto measure header heights, but never releases these references on Activity destruction. This creates a strong reference chain (ScreenDummyLayoutHelper → Views → ContextThemeWrapper → Activity) that prevents GC of destroyed Activities.The leak is caused by a combination of:
lateinit varfields that cannot be set tonullLifecycleEventListenerconditionally registered (skipped when init succeeds in constructor)onHostResumeafter successful initonHostDestroyonly removing the listener without releasing view referencescomputeDummyLayoutand potential cleanupChanges
lateinit varto nullablevar? = nullto allow reference releaseLifecycleEventListenerin constructor (regardless of init success)onHostDestroyis always calledisLayoutInitializedinonHostDestroyto break the reference chain and allow re-initialization on nextonHostResumecomputeDummyLayoutinsynchronized(this)block with null-safe local variables, returning0.0fas fallback when views are already cleaned uponHostDestroycleanup on the same monitor to prevent race conditionsTest plan
react-native-screensScreenDummyLayoutHelperinitializationChecklist