Skip to content

Improve usability of response specifications#2365

Merged
adamw merged 11 commits intomasterfrom
response-as-ux
Dec 12, 2024
Merged

Improve usability of response specifications#2365
adamw merged 11 commits intomasterfrom
response-as-ux

Conversation

@adamw
Copy link
Member

@adamw adamw commented Dec 10, 2024

Closes #1771

Changes:

  • introduce asXyzOrFail methods which throw exceptions for non-2xx responses
  • add asJsonOrFail, asJsonOrFailEither variants to all integrations
  • quickRequest now uses asStringOrFail as the default response type
  • scaladocs & docs updates
  • move .mapRight, .orFail to ResponseAs for better discoverability (instead of extension methods), however this causes that type parameters have to be provided explicitly sometimes

cc @bishabosha @lbialy

@bishabosha
Copy link

I like the new *orFail stuff (and good for json)

@adamw adamw merged commit d40b8e7 into master Dec 12, 2024
19 checks passed
@adamw adamw deleted the response-as-ux branch December 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Variant of asJson that always throws

2 participants