Fix avm install for legacy versions#4248
Open
Ansh-699 wants to merge 2 commits intosolana-foundation:masterfrom
Open
Fix avm install for legacy versions#4248Ansh-699 wants to merge 2 commits intosolana-foundation:masterfrom
Ansh-699 wants to merge 2 commits intosolana-foundation:masterfrom
Conversation
|
@Ansh-699 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
jamie-osec
reviewed
Feb 23, 2026
avm/src/lib.rs
Outdated
Comment on lines
458
to
469
Collaborator
There was a problem hiding this comment.
Suggested change
| match res.status() { | |
| StatusCode::NOT_FOUND => bail!( | |
| "No prebuilt binary found for version `{version}` (HTTP 404). \ | |
| Try `avm install {version} --from-source`." | |
| ), | |
| status if !status.is_success() => bail!( | |
| "Failed to download the binary for version `{version}` (status code: {})", | |
| res.status() | |
| ), | |
| _ => (), | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix avm install for <=0.30 by avoiding symlink collisions during source install and improving 404 messaging for missing binaries. Closes #4159.
fixed avm installs for older Anchor versions by installing from source into a temporary root and then moving the built binary into the versioned path, which avoids collisions with the anchor symlink, also improved error handling so missing prebuilt binaries return a clear 404 message and suggest --from-source, instead of a misleading “binary exists” failure.