chore: Increase verbosity of generate_create_account to avoid shadowing the evil solana ergonomic

[Arrowana]

Avoid reusing the term create_account as this is a system program instruction but the generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Also remove token or spl-program mentions since this function is used for non token businesses.

[vercel]

@Arrowana is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[jamie-osec]

generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Sorry, I'm a little unclear on what this means, can you elaborate?

[Arrowana]

generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Sorry, I'm a little unclear on what this means, can you elaborate?

Using only system_instruction::create_account opens to DOS because having lamports there will make it fail, so it does create account if no lamport or fund, allocate and assign when there are lamports. This is to make it clear that the generated code does the steps rather than reusing create_account, which is not what it does

[jamie-osec]

Sounds like a nice clarification, thanks