Skip to content

chore: Increase verbosity of generate_create_account to avoid shadowing the evil solana ergonomic#4257

Open
Arrowana wants to merge 1 commit intosolana-foundation:masterfrom
Arrowana:chore/verbosity-greatest-footgun-in-solano
Open

chore: Increase verbosity of generate_create_account to avoid shadowing the evil solana ergonomic#4257
Arrowana wants to merge 1 commit intosolana-foundation:masterfrom
Arrowana:chore/verbosity-greatest-footgun-in-solano

Conversation

@Arrowana
Copy link
Contributor

@Arrowana Arrowana commented Feb 19, 2026

Avoid reusing the term create_account as this is a system program instruction but the generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Also remove token or spl-program mentions since this function is used for non token businesses.

@vercel
Copy link

vercel bot commented Feb 19, 2026

@Arrowana is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@Arrowana Arrowana force-pushed the chore/verbosity-greatest-footgun-in-solano branch from 70439f4 to b445546 Compare February 19, 2026 04:25
@jamie-osec
Copy link
Collaborator

generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Sorry, I'm a little unclear on what this means, can you elaborate?

@Arrowana
Copy link
Contributor Author

Arrowana commented Feb 19, 2026

generated code does the full dance to avoid impaling itself into the thorny solana ergonomics.

Sorry, I'm a little unclear on what this means, can you elaborate?

Using only system_instruction::create_account opens to DOS because having lamports there will make it fail, so it does create account if no lamport or fund, allocate and assign when there are lamports. This is to make it clear that the generated code does the steps rather than reusing create_account, which is not what it does

@jamie-osec
Copy link
Collaborator

Sounds like a nice clarification, thanks

@jamie-osec jamie-osec added documentation Improvements or additions to documentation lang Merge labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lang Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants