Fix size_of calculations for dynamically sized types in Lazy#4319
Open
jamie-osec wants to merge 3 commits intosolana-foundation:masterfrom
Open
Fix size_of calculations for dynamically sized types in Lazy#4319jamie-osec wants to merge 3 commits intosolana-foundation:masterfrom
size_of calculations for dynamically sized types in Lazy#4319jamie-osec wants to merge 3 commits intosolana-foundation:masterfrom
Conversation
|
@jamie-osec is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
acheroncrypto
approved these changes
Mar 18, 2026
Collaborator
acheroncrypto
left a comment
There was a problem hiding this comment.
The enum fix looks very elegant 👍
Collaborator
|
@jamie-osec Could you please update |
40e8b0f to
136cfea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues with
Lazywhich resulted in miscalculations for dynamically sized types.size_ofcalculation for the inner data was passed the full data including the tag byte, instead of the actual inner payload, resulting in potential size miscalculations[String; 5]) have non-homogenous sizes. Correct this by calculating the size of each elementThis can result in incorrect deserialisation, allowing malicious payloads to bypass security checks.