Skip to content

Conversation

@thetarnav
Copy link
Contributor

A afterRegisterGraph hook allows for both signals, stores and any other custom value registered with DEV.registerGraph to be captured by the devtools when they are created, and even if created outside of a reactive graph - unowned.
This also makes the afterCreateSignal hook, that I added before, pointless so I deprecated it. My bad for not thinking about this before.

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: ff874d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 13463502559

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 153 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.5%) to 85.143%

Files with Coverage Reduction New Missed Lines %
packages/solid/src/reactive/scheduler.ts 1 80.95%
packages/solid/src/index.ts 2 50.0%
packages/solid/store/src/store.ts 2 97.46%
packages/solid/src/render/flow.ts 4 90.95%
packages/solid/src/reactive/array.ts 6 83.4%
packages/solid/src/render/component.ts 9 86.17%
packages/solid/store/src/mutable.ts 18 75.44%
packages/solid/src/reactive/signal.ts 111 81.69%
Totals Coverage Status
Change from base Build 11846786421: -0.5%
Covered Lines: 2285
Relevant Lines: 2614

💛 - Coveralls

@ryansolid ryansolid merged commit f9ef621 into solidjs:main Feb 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants