added logic to abort applying the scPlayer() if the source element has already had an scPlayer assigned#58
Open
lvl99 wants to merge 1 commit intosoundcloud:masterfrom
Open
added logic to abort applying the scPlayer() if the source element has already had an scPlayer assigned#58lvl99 wants to merge 1 commit intosoundcloud:masterfrom
lvl99 wants to merge 1 commit intosoundcloud:masterfrom
Conversation
…s already had an scPlayer assigned I found through some dodgy code of my own that multiple calls of scPlayer() to a source element weren't being aborted if the scPlayer() functionality was already applied. I think ideally all the DOM-crawling var setting logic would follow the abort code so as to lower any unnecessary overhead. Signed-off-by: Matt Scheurich <matt@lvl99.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found through some dodgy JS code of my own that multiple calls of
scPlayer()on a source element weren't being aborted if thescPlayer()functionality was already applied. This resulted in the internal links of the generatedscPlayer()element (such as#play,#pause,#info, etc.) to then try to be referenced asscApiUrl()s which then resulted in errors and no media being loaded.I think ideally all the var setting logic which involves DOM-crawling would follow the abort code so as to lower any further unnecessary overheads.