Add option to CLI, App and add_api to disable security verification.#1874
Open
mjp4 wants to merge 2 commits intospec-first:mainfrom
Open
Add option to CLI, App and add_api to disable security verification.#1874mjp4 wants to merge 2 commits intospec-first:mainfrom
mjp4 wants to merge 2 commits intospec-first:mainfrom
Conversation
Member
|
Thanks @mjp4! Agree that this would be useful, we use a gateway for security as well. I'm still thinking about the approach though. Another option would be to remove the If we add this option, we should update the documentation example you linked though to prevent confusion. |
Member
|
I would prefer removing the security middleware from the stack so we don't need to pass the information along everywhere. For example, imo the security middleware shouldn't have to parse this option but we should not have the security middleware in the middleware stack as a whole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: