chore(server/typescript): brand db to prevent incorrect db being used#4974
Draft
iainsproat wants to merge 1 commit intomainfrom
Draft
chore(server/typescript): brand db to prevent incorrect db being used#4974iainsproat wants to merge 1 commit intomainfrom
iainsproat wants to merge 1 commit intomainfrom
Conversation
- we can use typescript branding to catch use of incorrect db at build time - prevents regression of issue where project Db was used in place of main Db for API token creation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
==========================================
- Coverage 69.18% 61.70% -7.48%
==========================================
Files 600 541 -59
Lines 26139 23219 -2920
Branches 3837 3450 -387
==========================================
- Hits 18084 14328 -3756
- Misses 6871 8001 +1130
+ Partials 1184 890 -294 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References