feat(fe): filters panel popular filters buttons#5530
Open
andrewwallacespeckle wants to merge 3 commits intomainfrom
Open
feat(fe): filters panel popular filters buttons#5530andrewwallacespeckle wants to merge 3 commits intomainfrom
andrewwallacespeckle wants to merge 3 commits intomainfrom
Conversation
Contributor
|
@andrewwallacespeckle @michalspeckle Another approach could be launch with property search panel open when you enter the Filters panel. Could be handy – or a little confusing. I don't know. But it already has the "popular filters" listed. 
|
Contributor
I played around with this a bit, and showing the property list panel on page load looks better and feels more natural. I don’t see the same list twice, and the empty state panel looks cleaner. It’s not ideal that the panel covers the model that much but that’s a trade-off. On mobile we should probably avoid this behavior though and keep it as it is today (so click add or + to see the property list). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the FILTERS_POPULAR_PROPERTIES list based on mixpanel. We decide which properties to show based on the ordering in this list.
In the property selection panel, we currently have no limit on popular properties.
In EmptyState, we limit it to 6 popular properties, and it will never wrap into a third line.