Lift restrictions on command option names#14
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Dec 13, 2025
Merged
Lift restrictions on command option names#14patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
Before:
* [CommandOption("-f|--foo <F$OO>")] is invalid and throws CommandTemplateException
* [CommandOption("--f$oo")] is invalid and throws CommandTemplateException
After:
* [CommandOption("-f|--foo <F$OO>")] is valid
* [CommandOption("--f$oo")] is valid
patriksvensson
approved these changes
Dec 13, 2025
0xced
added a commit
to 0xced/nugraph
that referenced
this pull request
Dec 15, 2025
This reverts commit ca0d2b5. It doesn't actually work, despite spectreconsole/spectre.console.cli#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
As discussed in #8