regtests: add test "swapserver_server_skip_onchain_funding"#9986
Draft
SomberNight wants to merge 5 commits intospesmilo:masterfrom
Draft
regtests: add test "swapserver_server_skip_onchain_funding"#9986SomberNight wants to merge 5 commits intospesmilo:masterfrom
SomberNight wants to merge 5 commits intospesmilo:masterfrom
Conversation
SomberNight
force-pushed
the
202506_regtest_swapserver
branch
6 times, most recently
from
c47c51e to
b5d5020
Compare
Even if it decides there is nothing to sweep from the ctx/etc, it still needs to keep watching until a reorg-safe depth.
- the fabled return of the "inject_fees" command :D - also make fee_estimates.has_data() smarter, to ignore extraneous targets
- if fee estimates are high atm, some outputs are not worth to sweep
- however, fee estimates might be only-temporarily very high
- previously in such a case lnwatcher would just discard outputs as dust,
and mark the channel REDEEMED (and hence never watch it or try again)
- now, instead, if the outputs would not be dust if fee estimates were lower,
lnwatcher will keep watching the channel
- and if estimates go down, lnwatcher will sweep them then
- relatedly, previously txbatcher.is_dust() used allow_fallback_to_static_rates=True,
and it erroneously almost always fell back to the static rates (150 s/b) during
startup (race: lnwatcher was faster than the network managed to get estimates)
- now, instead, txbatcher.is_dust() does not fallback to static rates,
and the callers are supposed to handle NoDynamicFeeEstimates.
- I think this makes much more sense. The previous meaning of "is_dust"
with the fallback was weird. Now it means: "is dust at current feerates".
fixes spesmilo#9980
SomberNight
force-pushed
the
202506_regtest_swapserver
branch
from
b5d5020 to
d3f04a9
Compare
SomberNight
force-pushed
the
202506_regtest_swapserver
branch
from
d3f04a9 to
d7657c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #9980