fix: return os.ErrClosed on double Close() in MemMapFs#588
Open
Yanhu007 wants to merge 1 commit intospf13:masterfrom
Open
fix: return os.ErrClosed on double Close() in MemMapFs#588Yanhu007 wants to merge 1 commit intospf13:masterfrom
Yanhu007 wants to merge 1 commit intospf13:masterfrom
Conversation
MemMapFs File.Close() silently succeeds when called multiple times, while OsFs returns an error. This inconsistency causes bugs to go undetected in tests using MemMapFs that only surface in production with OsFs. Return os.ErrClosed when the file is already closed, matching the behavior of os.File. Fixes spf13#567
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567
Problem
mem.File.Close()silently succeeds when called multiple times, whileos.File.Close()returns an error (os.ErrClosed). This inconsistency causes bugs to go undetected in tests using MemMapFs that only surface in production with OsFs.Fix
Check the
closedflag under the lock before proceeding. If already closed, returnos.ErrClosedto matchos.Filebehavior.Testing
All existing tests pass.