feat(fish): implement ShellCompDirectiveFilterDirs#2372
Open
thaJeztah wants to merge 1 commit intospf13:mainfrom
Open
feat(fish): implement ShellCompDirectiveFilterDirs#2372thaJeztah wants to merge 1 commit intospf13:mainfrom
thaJeztah wants to merge 1 commit intospf13:mainfrom
Conversation
Fish supports directory-only completions through `__fish_complete_directories`, but Cobra's generated completion script treated this directive as unsupported. Use Fish's native directory completion when `ShellCompDirectiveFilterDirs` is set. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
|
Failure is unrelated to my changes, but perhaps GolangCi-lint was updated; |
ccoVeille
reviewed
Mar 20, 2026
| * `BashCompSubdirsInDir` (filtering by directory) | ||
| * The functions corresponding to the above annotations are consequently not supported and will be ignored for `fish`: | ||
| * `MarkFlagFilename()` and `MarkPersistentFlagFilename()` (filtering by file extension) | ||
| * `MarkFlagDirname()` and `MarkPersistentFlagDirname()` (filtering by directory) |
Contributor
There was a problem hiding this comment.
I'm unsure why this line was removed
Contributor
Author
There was a problem hiding this comment.
I need to double check when I'm back at my computer, but I think the flow was; these options set a "bash" annotation on the flag, but the code further down converts that to setting autocompletion for the flag, using the ShellCompDirectiveFilterDirs directive.
So they were ignored because that directive wasn't functional 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish supports directory-only completions through
__fish_complete_directories, but Cobra's generated completion script treated this directive as unsupported.Use Fish's native directory completion when
ShellCompDirectiveFilterDirsis set.