Skip to content

Mention Byte Buddy as cglib alternative in the documentation#1020

Merged
leonard84 merged 2 commits intospockframework:masterfrom
Vampire:mention-byte-buddy
Feb 10, 2020
Merged

Mention Byte Buddy as cglib alternative in the documentation#1020
leonard84 merged 2 commits intospockframework:masterfrom
Vampire:mention-byte-buddy

Conversation

@Vampire
Copy link
Copy Markdown
Member

@Vampire Vampire commented Aug 29, 2019

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2019

Codecov Report

Merging #1020 into master will increase coverage by 0.13%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1020      +/-   ##
============================================
+ Coverage        74%   74.14%   +0.13%     
- Complexity     3449     3471      +22     
============================================
  Files           385      385              
  Lines         10660    10677      +17     
  Branches       1301     1307       +6     
============================================
+ Hits           7889     7916      +27     
+ Misses         2309     2300       -9     
+ Partials        462      461       -1
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/spock/util/environment/Jvm.java 91.17% <100%> (+16.17%) 38 <21> (+13) ⬆️
...ockframework/mock/constraint/TargetConstraint.java 93.33% <85.71%> (-6.67%) 8 <1> (+4)
...ckframework/mock/runtime/ByteBuddyMockFactory.java 82.69% <0%> (ø) 9% <0%> (ø) ⬇️
...ockframework/mock/runtime/JavaMockInterceptor.java 92.3% <0%> (ø) 16% <0%> (ø) ⬇️
...e/extension/builtin/PendingFeatureIfExtension.java 76.47% <0%> (ø) 6% <0%> (ø) ⬇️
...va/org/spockframework/mock/runtime/MockObject.java 82.85% <0%> (-8.58%) 22% <0%> (-1%)
.../spockframework/util/StringMessagePrintStream.java 83.07% <0%> (ø) 23% <0%> (ø) ⬇️
...rc/main/groovy/spock/util/matcher/IsCloseTo.groovy 87.5% <0%> (ø) 6% <0%> (ø) ⬇️
.../spockframework/gentyref/GenericTypeReflector.java 35.23% <0%> (ø) 28% <0%> (ø) ⬇️
.../spockframework/builder/CollectionSlotFactory.java 88.88% <0%> (ø) 6% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a2cdf...479fb5c. Read the comment docs.

Copy link
Copy Markdown
Member

@leonard84 leonard84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually byte-buddy is the main and cglib the backup, if both are on the classpath, byte-buddy is used.

@Vampire Vampire force-pushed the mention-byte-buddy branch from f554b84 to cac4a88 Compare January 12, 2020 22:38
@Vampire
Copy link
Copy Markdown
Member Author

Vampire commented Jan 12, 2020

Actually byte-buddy is the main and cglib the backup, if both are on the classpath, byte-buddy is used.

I swapped the two in the sentence if that was what you meant.
If not, please be more specific.

@Vampire Vampire force-pushed the mention-byte-buddy branch from cac4a88 to 05cd8aa Compare January 12, 2020 22:40
Comment thread docs/interaction_based_testing.adoc Outdated
@Vampire Vampire force-pushed the mention-byte-buddy branch from 05cd8aa to a4fee75 Compare January 13, 2020 09:03
Comment thread docs/interaction_based_testing.adoc Outdated
Comment thread docs/interaction_based_testing.adoc Outdated
@szpak szpak added this to the 2.0 milestone Feb 4, 2020
@Vampire Vampire force-pushed the mention-byte-buddy branch from a4fee75 to 7263cbb Compare February 4, 2020 19:21
szpak
szpak previously approved these changes Feb 4, 2020
@Vampire Vampire force-pushed the mention-byte-buddy branch 5 times, most recently from d626267 to 84e761b Compare February 6, 2020 00:13
szpak
szpak previously approved these changes Feb 6, 2020
@leonard84 leonard84 merged commit 27fff22 into spockframework:master Feb 10, 2020
@Vampire Vampire deleted the mention-byte-buddy branch February 10, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants