Skip to content

Use new Console main class for Groovy 3+#1082

Merged
leonard84 merged 2 commits intospockframework:masterfrom
Vampire:groovy3
Feb 10, 2020
Merged

Use new Console main class for Groovy 3+#1082
leonard84 merged 2 commits intospockframework:masterfrom
Vampire:groovy3

Conversation

@Vampire
Copy link
Copy Markdown
Member

@Vampire Vampire commented Jan 21, 2020

This change is Reviewable

Comment thread build.gradle
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2020

Codecov Report

Merging #1082 into master will increase coverage by 0.13%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1082      +/-   ##
============================================
+ Coverage        74%   74.14%   +0.13%     
- Complexity     3449     3471      +22     
============================================
  Files           385      385              
  Lines         10660    10677      +17     
  Branches       1301     1307       +6     
============================================
+ Hits           7889     7916      +27     
+ Misses         2309     2300       -9     
+ Partials        462      461       -1
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/spock/util/environment/Jvm.java 91.17% <100%> (+16.17%) 38 <21> (+13) ⬆️
...ockframework/mock/constraint/TargetConstraint.java 93.33% <85.71%> (-6.67%) 8 <1> (+4)
...va/org/spockframework/mock/runtime/MockObject.java 82.85% <0%> (-8.58%) 22% <0%> (-1%)
...org/spockframework/compiler/DeepBlockRewriter.java 78.39% <0%> (+0.61%) 69% <0%> (+1%) ⬆️
...org/spockframework/compiler/SpecialMethodCall.java 88.73% <0%> (+1.4%) 42% <0%> (+1%) ⬆️
...kframework/compiler/AbstractDeepBlockRewriter.java 100% <0%> (+1.47%) 22% <0%> (+1%) ⬆️
...main/java/org/spockframework/compiler/AstUtil.java 62.68% <0%> (+1.49%) 56% <0%> (+2%) ⬆️
...g/spockframework/compiler/InteractionRewriter.java 72.92% <0%> (+2.2%) 52% <0%> (+2%) ⬆️
...kframework/mock/runtime/GroovyMockInterceptor.java 75.75% <0%> (+6.06%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d08909...d00116d. Read the comment docs.

Copy link
Copy Markdown
Member

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait with it until #1075 is merged.

@szpak szpak added this to the 2.0 milestone Feb 4, 2020
@szpak szpak force-pushed the szpak/groovy3 branch 4 times, most recently from ec92ba0 to 5def0a9 Compare February 8, 2020 21:00
@Vampire Vampire changed the base branch from szpak/groovy3 to master February 10, 2020 14:34
@leonard84 leonard84 merged commit 244bcce into spockframework:master Feb 10, 2020
@Vampire Vampire deleted the groovy3 branch February 10, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants