Skip to content

feat: relax outdated dependency constraints for gcloud and mock #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hiro-o918 wants to merge 2 commits into
base: master
Choose a base branch
from
+64 −91
Open

feat: relax outdated dependency constraints for gcloud and mock #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cbfd68
feat: relax outdated dependency constraints for gcloud and mock
hiro-o918 Apr 16, 2026
f00395e
fix: correct broken mock assertion in s3 test
hiro-o918 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ common = [
"HTTPretty==0.8.10",
"hypothesis>=6.7.0,<7.0.0",
"jsonschema",
"mock<2.0",
"mock",
"moto>=1.3.10,<5.0",
"mypy",
"mysql-connector-python",
Expand Down Expand Up @@ -106,9 +106,10 @@ dropbox = [
]

gcloud = [
"google-api-python-client>=1.6.6,<2.0",
"google-auth==1.4.1",
"google-auth-httplib2==0.0.3",
"google-api-python-client>=2.0",
"google-auth>=2.0",
"google-auth-httplib2>=0.2",
"httplib2>=0.22",
Comment on lines +109 to +112
Copy link
Copy Markdown
Collaborator

@dlstadther dlstadther Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do worry that by these not defining upper bounds that major releases will be allowed through and break things without warning. However, it would be limited only to users installing luigi[gcloud].

Would you be opposed to setting upper bounds on major version here?

]

hdp = [
Expand Down Expand Up @@ -159,7 +160,7 @@ test_unixsocket = [
]

visualizer = [
"mock<2.0",
"mock",
"selenium==3.0.2"
]

Expand Down
2 changes: 1 addition & 1 deletion test/contrib/s3_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def test_init_with_config(self, mock):
@with_config({"s3": {"aws_role_arn": "role", "aws_role_session_name": "name"}})
def test_init_with_config_and_roles(self, sts_mock, s3_mock):
S3Client().s3
sts_mock.client.assume_role.called_with(RoleArn="role", RoleSessionName="name")
sts_mock.return_value.assume_role.assert_called_with(RoleArn="role", RoleSessionName="name")

@patch("boto3.client")
def test_init_with_host_deprecated(self, mock):
Expand Down
Loading
Loading