Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ jobs:
# gemfile: "rails_6_1"
# - ruby: "2.7"
# gemfile: "rails_6_1"
- ruby: "2.6"
gemfile: "rails_6.1"
- ruby: "2.5"
gemfile: "rails_6.1"
- ruby: "3.4"
gemfile: "rails_8.0"
- ruby: "3.3"
gemfile: "rails_8.0"

# - ruby: "2.7"
# gemfile: "rails_6_0"
- ruby: "2.6"
gemfile: "rails_6.0"
- ruby: "2.5"
gemfile: "rails_6.0"
- ruby: "3.4"
gemfile: "rails_7.2"
- ruby: "3.3"
gemfile: "rails_7.2"

- ruby: "2.5"
gemfile: "rails_5.2"
- ruby: "3.3"
gemfile: "rails_7.1"
Comment on lines +29 to +30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing gemfile for Rails 7.1 CI combo
You’ve added a CI job for gemfile: "rails_7.1", but there’s no corresponding gemfiles/rails_7.1.gemfile in the changes. Please ensure that file is present or remove the combo to avoid CI failures.

🤖 Prompt for AI Agents
In .github/workflows/main.yml at lines 29 to 30, you added a CI job for gemfile
"rails_7.1" but did not include the corresponding gemfiles/rails_7.1.gemfile
file. To fix this, either add the missing rails_7.1.gemfile to the gemfiles
directory with the appropriate dependencies or remove the rails_7.1 gemfile
entry from the CI workflow to prevent failures.


runs-on: ubuntu-latest

Expand Down
16 changes: 8 additions & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
appraise 'rails-5.2' do
appraise 'rails-7.0' do
%w[
actionview
railties
].each do |rails_gem|
gem rails_gem, '~> 5.2.0'
gem rails_gem, '~> 7.0.0'
end
end

appraise 'rails-6.0' do
appraise 'rails-7.1' do
%w[
actionview
railties
].each do |rails_gem|
gem rails_gem, '~> 6.0.0'
gem rails_gem, '~> 7.1.0'
end
end

appraise 'rails-6.1' do
appraise 'rails-7.2' do
%w[
actionview
railties
].each do |rails_gem|
gem rails_gem, '~> 6.1.0'
gem rails_gem, '~> 7.2.0'
end
end

appraise 'rails-7.0' do
appraise 'rails-8.0' do
%w[
actionview
railties
].each do |rails_gem|
gem rails_gem, '~> 7.0.0'
gem rails_gem, '~> 8.0.0'
end
end
6 changes: 0 additions & 6 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
source 'https://rubygems.org'

group :test do
gem 'test-unit'
gem 'pry'
gem 'pry-byebug'
end

gemspec
22 changes: 14 additions & 8 deletions deface.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,24 +29,30 @@ Gem::Specification.new do |spec|
spec.rdoc_options = ["--charset=UTF-8"]
spec.extra_rdoc_files = ["README.markdown"]

spec.add_dependency('nokogiri', '>= 1.6')

%w[
actionview
railties
].each do |rails_gem|
spec.add_dependency(rails_gem, '>= 5.2')
spec.add_dependency(rails_gem, '>= 7.0')
end
spec.add_dependency('rainbow', '>= 2.1.0')

spec.add_dependency('base64')
spec.add_dependency('bigdecimal')
spec.add_dependency('drb')
spec.add_dependency('mutex_m')
spec.add_dependency('nokogiri', '>= 1.6')
spec.add_dependency('polyglot')
spec.add_dependency('rainbow', '>= 2.1.0')

spec.add_development_dependency('appraisal')
spec.add_development_dependency('erubis')
spec.add_development_dependency('gem-release')
spec.add_development_dependency('rspec', '>= 3.1.0')
spec.add_development_dependency('haml', ['>= 4.0', '< 6'])
spec.add_development_dependency('slim', '~> 4.1')
spec.add_development_dependency('simplecov', '>= 0.6.4')
spec.add_development_dependency('generator_spec', '~> 0.8')
spec.add_development_dependency('haml', ['>= 4.0', '< 6'])
spec.add_development_dependency('pry')
spec.add_development_dependency('pry-byebug')
spec.add_development_dependency('rspec', '>= 3.1.0')
spec.add_development_dependency('simplecov', '>= 0.6.4')
spec.add_development_dependency('slim', '~> 4.1')
spec.add_development_dependency('test-unit')
end
6 changes: 0 additions & 6 deletions gemfiles/rails_7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,4 @@ source "https://rubygems.org"
gem "actionview", "~> 7.0.0"
gem "railties", "~> 7.0.0"

group :test do
gem "test-unit"
gem "pry"
gem "pry-byebug"
end

gemspec path: "../"
8 changes: 8 additions & 0 deletions gemfiles/rails_7.1.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "actionview", "~> 7.1.0"
gem "railties", "~> 7.1.0"

gemspec path: "../"
8 changes: 8 additions & 0 deletions gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "actionview", "~> 7.2.0"
gem "railties", "~> 7.2.0"

gemspec path: "../"
8 changes: 8 additions & 0 deletions gemfiles/rails_8.0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "actionview", "~> 8.0.0"
gem "railties", "~> 8.0.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion spec/deface/precompiler_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module Deface

filename = 'spec/dummy/app/compiled_views/posts/precompileme.html.erb'

expect(File.exists?(filename)).to be_truthy
expect(File.exist?(filename)).to be_truthy

file = File.open(filename, "rb")
contents = file.read
Expand Down