saml: make response/assertion compliant with SAML v2.0#20
Open
hpedrorodrigues wants to merge 4 commits intossoready:mainfrom
Open
saml: make response/assertion compliant with SAML v2.0#20hpedrorodrigues wants to merge 4 commits intossoready:mainfrom
hpedrorodrigues wants to merge 4 commits intossoready:mainfrom
Conversation
|
@hpedrorodrigues is attempting to deploy a commit to the SSOReady Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hey @ucarion 👋🏻 Is there anything else I can do to move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋🏻
First of all, thanks for working on this project! 🚀
Problem Description
I tried to use this project with Keycloak (KC as a service provider and later as an identity broker), but encountered a few issues along the way. So, decided to open this pull request in case it can help others.
Proposed changes
getBaseUrlfunction to properly compute protocol + domain (and port). This is required to better support running this project on a local device.NEXT_PUBLIC_DUMMYIDP_CUSTOM_DOMAIN=localhost:3000, it tries to use HTTPS.NEXT_PUBLIC_DUMMYIDP_CUSTOM_DOMAINis set, it doesn't use a valid "default" address.ID,IssueInstant, andVersion) and assertion (IssueInstantandVersion), and took the opportunity to add a few optional attributes as well (e.g.,InResponseTo).Status).email. Even though most of the time it'll be equal to the Name ID, there are cases where IdPs use an external ID for Name ID, making it required to use a separate statement to pass/extract the email.xmltag template function to make it a bit easier to write XMLs and reason about them.Reference
I implemented these changes based on the SAML v2.0 specification and Keycloak's Server Administration Guide.
I also used samltool.io to check assertions (e.g.,
signature, etc.).Versions
I tested these changes with the following versions:
Fixes
#18
Notes
Please let me know if you have any concerns/feedback, and if this makes sense for the project.