WIP enhancement(controller): add type for step spec - #3076
Open
goldenxinxing wants to merge 11 commits into
Open
WIP enhancement(controller): add type for step spec#3076goldenxinxing wants to merge 11 commits into
goldenxinxing wants to merge 11 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3076 +/- ##
============================================
- Coverage 82.70% 73.40% -9.30%
+ Complexity 3211 3192 -19
============================================
Files 571 436 -135
Lines 31789 15866 -15923
Branches 1873 1873
============================================
- Hits 26290 11647 -14643
+ Misses 4677 3393 -1284
- Partials 822 826 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
goldenxinxing
marked this pull request as ready for review
December 14, 2023 06:13
anda-ren
reviewed
Dec 14, 2023
| class StepType(Enum): | ||
| evaluation = 'EVALUATION' | ||
| fine_tune = 'FINE_TUNE' | ||
| serving = 'SERVING' |
Member
There was a problem hiding this comment.
shall we add plain or customized type for @handler annotation
| require_dataset: bool = False, | ||
| built_in: bool = False, | ||
| fine_tune: FineTune | None = None, | ||
| typ: StepType | None = None, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO list:
Modules
Checklist