Skip to content

WIP enhancement(controller): add type for step spec - #3076

Open
goldenxinxing wants to merge 11 commits into
star-whale:mainfrom
goldenxinxing:feat/add-type-for-step-spec
Open

WIP enhancement(controller): add type for step spec#3076
goldenxinxing wants to merge 11 commits into
star-whale:mainfrom
goldenxinxing:feat/add-type-for-step-spec

Conversation

@goldenxinxing

@goldenxinxing goldenxinxing commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

Description

  1. add type for step
  2. fix enum serialization error

TODO list:

  1. add validation in ui
  2. add validation in server api

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the enhancement ❤️ New feature or request label Dec 12, 2023
@goldenxinxing goldenxinxing changed the title feat(controller): add type for step spec enhancement(controller): add type for step spec Dec 12, 2023
@codecov

codecov Bot commented Dec 12, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.40%. Comparing base (bca9510) to head (5f84a58).
⚠️ Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/ai/starwhale/mlops/api/JobController.java 0.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (bca9510) and HEAD (5f84a58). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (bca9510) HEAD (5f84a58)
unittests 11 1
standalone 10 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3076      +/-   ##
============================================
- Coverage     82.70%   73.40%   -9.30%     
+ Complexity     3211     3192      -19     
============================================
  Files           571      436     -135     
  Lines         31789    15866   -15923     
  Branches       1873     1873              
============================================
- Hits          26290    11647   -14643     
+ Misses         4677     3393    -1284     
- Partials        822      826       +4     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller 73.42% <66.66%> (-0.12%) ⬇️
standalone ?
unittests 72.09% <ø> (-19.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@goldenxinxing
goldenxinxing marked this pull request as ready for review December 14, 2023 06:13
class StepType(Enum):
evaluation = 'EVALUATION'
fine_tune = 'FINE_TUNE'
serving = 'SERVING'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add plain or customized type for @handler annotation

require_dataset: bool = False,
built_in: bool = False,
fine_tune: FineTune | None = None,
typ: StepType | None = None,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mabe typo for type: StepType

@goldenxinxing goldenxinxing changed the title enhancement(controller): add type for step spec WIP enhancement(controller): add type for step spec Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ❤️ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants