[9.x] Fix validation on published field#792
Merged
duncanmcclean merged 1 commit into9.xfrom Mar 25, 2026
Merged
Conversation
|
Released as part of v9.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
required_if:published,truevalidation rules don't work with the native "published" field on publishable Runway resources.This was happening because when a Runway resource is publishable, the
publishedfield is a native/automatic field that isn't part of the blueprint. During validation, only fields defined in the blueprint are processed, so thepublishedvalue wasn't available for conditional validation rules likerequired_if:published,true.This PR fixes it by adding the published field to the blueprint before validation in both the
store()andupdate()methods, mirroring the pattern already used inprepareModelForSaving().Fixes #790