fix: sign-transactions balances call should fail silently #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view. Tweaks logic for insufficient balance warning to degrade silently in case of balance failures. Adds test cases for balance failures in the sign transaction flow
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #2437 by making the account balance fetch in the sign transaction flow fail silently. Previously, if the balance API call failed (e.g., due to network connectivity issues), users were blocked from signing transactions with an error. Now, the balance fetch failure is handled gracefully, allowing users to proceed with signing transactions even when balances cannot be loaded.
Changes:
- Modified balance fetching in
useGetSignTxDatato handle failures silently by catching errors and setting balances toundefined - Updated the
ResolvedDatainterface to make thebalancesfield optional - Changed the insufficient balance check in
SignTransactionto skip the warning when balances are unavailable - Added comprehensive test coverage for the new behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| extension/src/popup/views/SignTransaction/hooks/useGetSignTxData.tsx | Added try-catch block around balance fetching to handle failures silently, removed error-throwing logic, and made balances field optional in ResolvedData interface |
| extension/src/popup/views/SignTransaction/index.tsx | Updated balance check logic to handle undefined balances by defaulting to allowing the user to proceed |
| extension/src/popup/views/tests/SignTransaction.test.tsx | Added test case for rendering sign transaction view when balances are unavailable, with minor inconsistency in using hardcoded network passphrase |
| extension/src/popup/views/SignTransaction/hooks/tests/useGetSignTxData.test.tsx | Added test case to verify graceful handling of balance fetch failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
piyalbasu
reviewed
Jan 30, 2026
extension/src/popup/views/SignTransaction/hooks/useGetSignTxData.tsx
Outdated
Show resolved
Hide resolved
piyalbasu
reviewed
Jan 30, 2026
piyalbasu
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2437
Why
If a user is in the sign-transaction flow and the call to fetch their balances fails, we fail harshly and block them from completing the transaction.
What
This handles the failure silently and allows the user to continue in their flow, the only side effect is that we cannot warn them about a potential insufficient balance.